Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2803843002: Change Modulator functions to use ScriptState instead of LocalFrame (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Modulator functions to use ScriptState instead of LocalFrame Follow up to http://crrev.com/2795593006, changes Modulator::from/setModulator/clearModulator to take ScriptState* as a parameter instead of LocalFrame* BUG=682322 Review-Url: https://codereview.chromium.org/2803843002 Cr-Commit-Position: refs/heads/master@{#462856} Committed: https://chromium.googlesource.com/chromium/src/+/29fbaae716e6ed69a2be3ef27655bb493f6f0444

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 2 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
adithyas
3 years, 8 months ago (2017-04-06 19:06:04 UTC) #3
jbroman
lgtm
3 years, 8 months ago (2017-04-06 19:54:48 UTC) #5
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-06 23:53:41 UTC) #8
haraken
LGTM
3 years, 8 months ago (2017-04-07 01:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803843002/40001
3 years, 8 months ago (2017-04-07 14:12:46 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 14:40:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/29fbaae716e6ed69a2be3ef27655...

Powered by Google App Engine
This is Rietveld 408576698