Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: third_party/WebKit/Source/core/dom/Modulator.cpp

Issue 2803843002: Change Modulator functions to use ScriptState instead of LocalFrame (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Modulator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Modulator.cpp
diff --git a/third_party/WebKit/Source/core/dom/Modulator.cpp b/third_party/WebKit/Source/core/dom/Modulator.cpp
index 8350bcc85d1a7793228ec9bedffe24be699d122b..0406a7f522e16176d83f0f07e2236618def853f9 100644
--- a/third_party/WebKit/Source/core/dom/Modulator.cpp
+++ b/third_party/WebKit/Source/core/dom/Modulator.cpp
@@ -11,20 +11,12 @@ namespace blink {
namespace {
const char kPerContextDataKey[] = "Modulator";
+} // namespace
-V8PerContextData* getPerContextData(LocalFrame* frame) {
- ScriptState* scriptState = toScriptStateForMainWorld(frame);
+Modulator* Modulator::from(ScriptState* scriptState) {
if (!scriptState)
return nullptr;
- return scriptState->perContextData();
-}
-} // namespace
-
-Modulator* Modulator::from(LocalFrame* frame) {
- return from(getPerContextData(frame));
-}
-
-Modulator* Modulator::from(V8PerContextData* perContextData) {
+ V8PerContextData* perContextData = scriptState->perContextData();
if (!perContextData)
return nullptr;
return static_cast<Modulator*>(perContextData->getData(kPerContextDataKey));
@@ -32,14 +24,16 @@ Modulator* Modulator::from(V8PerContextData* perContextData) {
Modulator::~Modulator() {}
-void Modulator::setModulator(LocalFrame* frame, Modulator* modulator) {
- V8PerContextData* perContextData = getPerContextData(frame);
+void Modulator::setModulator(ScriptState* scriptState, Modulator* modulator) {
+ DCHECK(scriptState);
+ V8PerContextData* perContextData = scriptState->perContextData();
DCHECK(perContextData);
perContextData->addData(kPerContextDataKey, modulator);
}
-void Modulator::clearModulator(LocalFrame* frame) {
- V8PerContextData* perContextData = getPerContextData(frame);
+void Modulator::clearModulator(ScriptState* scriptState) {
+ DCHECK(scriptState);
+ V8PerContextData* perContextData = scriptState->perContextData();
DCHECK(perContextData);
perContextData->clearData(kPerContextDataKey);
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Modulator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698