Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2803693007: Adjust appearance of omnibox keyword hint view for on-screen keyboards. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
sadrul, Peter Kasting
CC:
chromium-reviews, tfarina, oka+watchvk_chromium.org, yhanada+watchvk_chromium.org, dfaden+virtualkb_google.com, srahim+watch_chromium.org, groby+virtualkb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust appearance of omnibox keyword hint view for on-screen keyboards. BUG=698422 Review-Url: https://codereview.chromium.org/2803693007 Cr-Commit-Position: refs/heads/master@{#463089} Committed: https://chromium.googlesource.com/chromium/src/+/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0

Patch Set 1 #

Patch Set 2 : doc update #

Patch Set 3 : self review #

Total comments: 10

Patch Set 4 : pkasting feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -59 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.h View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 1 2 3 4 chunks +49 lines, -37 lines 0 comments Download
M ui/keyboard/keyboard_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 5 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Evan Stade
+sadrul for (minor) //ui/keyboard/ changes +pkasting for the rest
3 years, 8 months ago (2017-04-07 16:43:06 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/2803693007/diff/40001/chrome/browser/ui/views/location_bar/keyword_hint_view.cc File chrome/browser/ui/views/location_bar/keyword_hint_view.cc (right): https://codereview.chromium.org/2803693007/diff/40001/chrome/browser/ui/views/location_bar/keyword_hint_view.cc#newcode27 chrome/browser/ui/views/location_bar/keyword_hint_view.cc:27: // This view kinda looks like a keyboard ...
3 years, 8 months ago (2017-04-07 18:14:15 UTC) #7
sadrul
lgtm
3 years, 8 months ago (2017-04-07 22:40:08 UTC) #8
Evan Stade
https://codereview.chromium.org/2803693007/diff/40001/chrome/browser/ui/views/location_bar/keyword_hint_view.cc File chrome/browser/ui/views/location_bar/keyword_hint_view.cc (right): https://codereview.chromium.org/2803693007/diff/40001/chrome/browser/ui/views/location_bar/keyword_hint_view.cc#newcode27 chrome/browser/ui/views/location_bar/keyword_hint_view.cc:27: // This view kinda looks like a keyboard key. ...
3 years, 8 months ago (2017-04-08 00:07:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803693007/60001
3 years, 8 months ago (2017-04-08 00:08:05 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 01:06:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3578d3111a37b2ee39f306bb285a...

Powered by Google App Engine
This is Rietveld 408576698