Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2803693004:
chromeos: Remove unused strings from ash (Closed)
|
Created:
3 years, 8 months ago by James Cook Modified:
3 years, 8 months ago Reviewers:
tdanderson CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionchromeos: Remove unused strings from ash
Most of them probably became unreferenced in the MD status tray conversion.
BUG=708824
TEST=compiles
R=tdanderson@chromium.org
NO_DEPENDENCY_CHECKS=true
Review-Url: https://codereview.chromium.org/2803693004
Cr-Commit-Position: refs/heads/master@{#462595}
Committed: https://chromium.googlesource.com/chromium/src/+/cf38158add6214df8d0779816c854429ccc6208e
Patch Set 1 #
Total comments: 1
Depends on Patchset: Messages
Total messages: 21 (13 generated)
tdanderson, please take a look.
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Were you also planning to run chrome/app/chromeos_strings.grdp through the script? https://codereview.chromium.org/2803693004/diff/1/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/2803693004/diff/1/ash/ash_strings.grd#newcode3 ash/ash_strings.grd:3: <!-- nit: Please include BUG=708824 in the CL description.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== chromeos: Remove unused strings from ash Most of them probably became unreferenced in the MD status tray conversion. BUG=none TEST=compiles R=tdanderson@chromium.org ========== to ========== chromeos: Remove unused strings from ash Most of them probably became unreferenced in the MD status tray conversion. BUG=708824 TEST=compiles R=tdanderson@chromium.org ==========
CL description fixed. I'll do the other ones later, unless someone beats me to it. There are dozens of unused strings, all across chrome.
The CQ bit was checked by jamescook@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2802723005 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== chromeos: Remove unused strings from ash Most of them probably became unreferenced in the MD status tray conversion. BUG=708824 TEST=compiles R=tdanderson@chromium.org ========== to ========== chromeos: Remove unused strings from ash Most of them probably became unreferenced in the MD status tray conversion. BUG=708824 TEST=compiles R=tdanderson@chromium.org NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491507857933480, "parent_rev":
"069464ff67c5ba19b7a0aff04cd88cb646872d81", "commit_rev":
"cf38158add6214df8d0779816c854429ccc6208e"}
Message was sent while issue was closed.
Description was changed from ========== chromeos: Remove unused strings from ash Most of them probably became unreferenced in the MD status tray conversion. BUG=708824 TEST=compiles R=tdanderson@chromium.org NO_DEPENDENCY_CHECKS=true ========== to ========== chromeos: Remove unused strings from ash Most of them probably became unreferenced in the MD status tray conversion. BUG=708824 TEST=compiles R=tdanderson@chromium.org NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2803693004 Cr-Commit-Position: refs/heads/master@{#462595} Committed: https://chromium.googlesource.com/chromium/src/+/cf38158add6214df8d0779816c85... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cf38158add6214df8d0779816c85... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
