Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 2802723005: tools: Fix extensions path in check_grd_for_unused_strings.py (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

tools: Fix extensions path in check_grd_for_unused_strings.py At some point extensions strings moved into extensions/strings. BUG=none TEST=runs Review-Url: https://codereview.chromium.org/2802723005 Cr-Commit-Position: refs/heads/master@{#462586} Committed: https://chromium.googlesource.com/chromium/src/+/488cf9d4df464eae28a1f1400086d3fa37ad237d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/check_grd_for_unused_strings.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
James Cook
estade, please take a look. The tool crashes if a path is wrong. The other ...
3 years, 8 months ago (2017-04-06 15:48:15 UTC) #2
Evan Stade
lgtm
3 years, 8 months ago (2017-04-06 16:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802723005/1
3 years, 8 months ago (2017-04-06 17:40:07 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:40:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/488cf9d4df464eae28a1f1400086...

Powered by Google App Engine
This is Rietveld 408576698