Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups (patchset #1 id:1 of https://codereview.chromium.org/2802673002/ )

Reason for revert:
Reland after the MediaRecorder problem is addressed on https://bugs.chromium.org/p/chromium/issues/detail?id=676424#c3.

Original issue's description:
> Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups (patchset #1 id:1 of https://codereview.chromium.org/2791733002/ )
> 
> Reason for revert:
> Speculative revert.
> Possibly breaks WebRTC Mac FYI bots.
> Will reland if the revert does not fix the bots.
> 
> Original issue's description:
> > Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
> > 
> > This CL makes sure that we create a HW encoder session only when 
> > MaxFrameDelayCount can be set. In case of multiple video streams, Video
> > Toolbox can set this variable up to 8, which results in a ~240 ms delay. We 
> > should just fall back to SW in those cases.
> > Additional cleanups:
> > - Remove the unused buffer pool attributes.
> > - Since MaxFrameDelayCount can only be set when 
> > RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
> > logic.
> > 
> > BUG=707309
> > TEST=Demo trying resolutions scaling down https://jsfiddle.net/emircan/jhonduk5/.
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > 
> > Review-Url: https://codereview.chromium.org/2791733002
> > Cr-Commit-Position: refs/heads/master@{#461245}
> > Committed: https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64
> 
> TBR=sandersd@chromium.org,emircan@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=707309
> 
> Review-Url: https://codereview.chromium.org/2802673002
> Cr-Commit-Position: refs/heads/master@{#462053}
> Committed: https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1947792ab15d6

TBR=sandersd@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707309
Review-Url: https://codereview.chromium.org/2803673004
Cr-Commit-Position: refs/heads/master@{#462576}
Committed: https://chromium.googlesource.com/chromium/src/+/882f01ad7ceb6c3c82a8bfa8dcf4982abb7d63d4

[emircan, 2017-04-06 16:06:33]

Created Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and
cleanups

[emircan, 2017-04-06 16:06:56]

The CQ bit was checked by emircan@chromium.org

[emircan, 2017-04-06 16:09:05]

Description was changed from

==========
Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2802673002/ )

Reason for revert:
Reland after the MediaRecorder problem is addressed on
https://bugs.chromium.org/p/chromium/issues/detail?id=676424#c3.

Original issue's description:
> Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2791733002/ )
> 
> Reason for revert:
> Speculative revert.
> Possibly breaks WebRTC Mac FYI bots.
> Will reland if the revert does not fix the bots.
> 
> Original issue's description:
> > Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
> > 
> > This CL makes sure that we create a HW encoder session only when 
> > MaxFrameDelayCount can be set. In case of multiple video streams, Video
> > Toolbox can set this variable up to 8, which results in a ~240 ms delay. We 
> > should just fall back to SW in those cases.
> > Additional cleanups:
> > - Remove the unused buffer pool attributes.
> > - Since MaxFrameDelayCount can only be set when 
> > RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
> > logic.
> > 
> > BUG=707309
> > TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > 
> > Review-Url: https://codereview.chromium.org/2791733002
> > Cr-Commit-Position: refs/heads/master@{#461245}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af...
> 
> TBR=sandersd@chromium.org,emircan@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=707309
> 
> Review-Url: https://codereview.chromium.org/2802673002
> Cr-Commit-Position: refs/heads/master@{#462053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1...

TBR=sandersd@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707309
==========

to

==========
Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2802673002/ )

Reason for revert:
Reland after the MediaRecorder problem is addressed on
https://bugs.chromium.org/p/chromium/issues/detail?id=676424#c3.

Original issue's description:
> Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2791733002/ )
> 
> Reason for revert:
> Speculative revert.
> Possibly breaks WebRTC Mac FYI bots.
> Will reland if the revert does not fix the bots.
> 
> Original issue's description:
> > Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
> > 
> > This CL makes sure that we create a HW encoder session only when 
> > MaxFrameDelayCount can be set. In case of multiple video streams, Video
> > Toolbox can set this variable up to 8, which results in a ~240 ms delay. We 
> > should just fall back to SW in those cases.
> > Additional cleanups:
> > - Remove the unused buffer pool attributes.
> > - Since MaxFrameDelayCount can only be set when 
> > RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
> > logic.
> > 
> > BUG=707309
> > TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > 
> > Review-Url: https://codereview.chromium.org/2791733002
> > Cr-Commit-Position: refs/heads/master@{#461245}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af...
> 
> TBR=sandersd@chromium.org,emircan@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=707309
> 
> Review-Url: https://codereview.chromium.org/2802673002
> Cr-Commit-Position: refs/heads/master@{#462053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1...

TBR=sandersd@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707309
==========

[emircan, 2017-04-06 16:09:05]

emircan@chromium.org changed reviewers:
- guidou@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sandersd (OOO until July 31), 2017-04-06 19:16:10]

lgtm

[commit-bot: I haz the power, 2017-04-06 19:17:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491494816978710, "parent_rev":
"73d1c7107a41b474c6fed9292ff41f7ce3429a42", "commit_rev":
"882f01ad7ceb6c3c82a8bfa8dcf4982abb7d63d4"}

[commit-bot: I haz the power, 2017-04-06 19:17:54]

Description was changed from

==========
Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2802673002/ )

Reason for revert:
Reland after the MediaRecorder problem is addressed on
https://bugs.chromium.org/p/chromium/issues/detail?id=676424#c3.

Original issue's description:
> Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2791733002/ )
> 
> Reason for revert:
> Speculative revert.
> Possibly breaks WebRTC Mac FYI bots.
> Will reland if the revert does not fix the bots.
> 
> Original issue's description:
> > Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
> > 
> > This CL makes sure that we create a HW encoder session only when 
> > MaxFrameDelayCount can be set. In case of multiple video streams, Video
> > Toolbox can set this variable up to 8, which results in a ~240 ms delay. We 
> > should just fall back to SW in those cases.
> > Additional cleanups:
> > - Remove the unused buffer pool attributes.
> > - Since MaxFrameDelayCount can only be set when 
> > RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
> > logic.
> > 
> > BUG=707309
> > TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > 
> > Review-Url: https://codereview.chromium.org/2791733002
> > Cr-Commit-Position: refs/heads/master@{#461245}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af...
> 
> TBR=sandersd@chromium.org,emircan@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=707309
> 
> Review-Url: https://codereview.chromium.org/2802673002
> Cr-Commit-Position: refs/heads/master@{#462053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1...

TBR=sandersd@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707309
==========

to

==========
Reland of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2802673002/ )

Reason for revert:
Reland after the MediaRecorder problem is addressed on
https://bugs.chromium.org/p/chromium/issues/detail?id=676424#c3.

Original issue's description:
> Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
(patchset #1 id:1 of https://codereview.chromium.org/2791733002/ )
> 
> Reason for revert:
> Speculative revert.
> Possibly breaks WebRTC Mac FYI bots.
> Will reland if the revert does not fix the bots.
> 
> Original issue's description:
> > Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
> > 
> > This CL makes sure that we create a HW encoder session only when 
> > MaxFrameDelayCount can be set. In case of multiple video streams, Video
> > Toolbox can set this variable up to 8, which results in a ~240 ms delay. We 
> > should just fall back to SW in those cases.
> > Additional cleanups:
> > - Remove the unused buffer pool attributes.
> > - Since MaxFrameDelayCount can only be set when 
> > RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
> > logic.
> > 
> > BUG=707309
> > TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > 
> > Review-Url: https://codereview.chromium.org/2791733002
> > Cr-Commit-Position: refs/heads/master@{#461245}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af...
> 
> TBR=sandersd@chromium.org,emircan@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=707309
> 
> Review-Url: https://codereview.chromium.org/2802673002
> Cr-Commit-Position: refs/heads/master@{#462053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1...

TBR=sandersd@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707309

Review-Url: https://codereview.chromium.org/2803673004
Cr-Commit-Position: refs/heads/master@{#462576}
Committed:
https://chromium.googlesource.com/chromium/src/+/882f01ad7ceb6c3c82a8bfa8dcf4...
==========

[commit-bot: I haz the power, 2017-04-06 19:17:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/882f01ad7ceb6c3c82a8bfa8dcf4...