Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2802673002: Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, mac-reviews_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups (patchset #1 id:1 of https://codereview.chromium.org/2791733002/ ) Reason for revert: Speculative revert. Possibly breaks WebRTC Mac FYI bots. Will reland if the revert does not fix the bots. Original issue's description: > Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups > > This CL makes sure that we create a HW encoder session only when > MaxFrameDelayCount can be set. In case of multiple video streams, Video > Toolbox can set this variable up to 8, which results in a ~240 ms delay. We > should just fall back to SW in those cases. > Additional cleanups: > - Remove the unused buffer pool attributes. > - Since MaxFrameDelayCount can only be set when > RequireHardwareAcceleratedVideoEncoder works, remove the other fallback > logic. > > BUG=707309 > TEST=Demo trying resolutions scaling down https://jsfiddle.net/emircan/jhonduk5/. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2791733002 > Cr-Commit-Position: refs/heads/master@{#461245} > Committed: https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64 TBR=sandersd@chromium.org,emircan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707309 Review-Url: https://codereview.chromium.org/2802673002 Cr-Commit-Position: refs/heads/master@{#462053} Committed: https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1947792ab15d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -17 lines) Patch
M media/gpu/vt_video_encode_accelerator_mac.h View 1 chunk +6 lines, -2 lines 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 6 chunks +37 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
3 years, 8 months ago (2017-04-05 12:39:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802673002/1
3 years, 8 months ago (2017-04-05 12:40:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1947792ab15d6
3 years, 8 months ago (2017-04-05 13:40:35 UTC) #6
emircan
3 years, 8 months ago (2017-04-06 16:06:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2803673004/ by emircan@chromium.org.

The reason for reverting is: Reland after the MediaRecorder problem is addressed
on https://bugs.chromium.org/p/chromium/issues/detail?id=676424#c3..

Powered by Google App Engine
This is Rietveld 408576698