Chromium Code Reviews
DescriptionRevert of Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups (patchset #1 id:1 of https://codereview.chromium.org/2791733002/ )
Reason for revert:
Speculative revert.
Possibly breaks WebRTC Mac FYI bots.
Will reland if the revert does not fix the bots.
Original issue's description:
> Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups
>
> This CL makes sure that we create a HW encoder session only when
> MaxFrameDelayCount can be set. In case of multiple video streams, Video
> Toolbox can set this variable up to 8, which results in a ~240 ms delay. We
> should just fall back to SW in those cases.
> Additional cleanups:
> - Remove the unused buffer pool attributes.
> - Since MaxFrameDelayCount can only be set when
> RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
> logic.
>
> BUG=707309
> TEST=Demo trying resolutions scaling down https://jsfiddle.net/emircan/jhonduk5/.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2791733002
> Cr-Commit-Position: refs/heads/master@{#461245}
> Committed: https://chromium.googlesource.com/chromium/src/+/7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64
TBR=sandersd@chromium.org,emircan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707309
Review-Url: https://codereview.chromium.org/2802673002
Cr-Commit-Position: refs/heads/master@{#462053}
Committed: https://chromium.googlesource.com/chromium/src/+/7e6cf6cadac69de4d9c38b71dee1947792ab15d6
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||