[Home] Fix status bar color on tab mode switch

[Home] Fix status bar color on tab mode switch

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

This change also adds a special case for the incognito NTP, since
that page is completely dark, that status bar should be too.

BUG=708680
Review-Url: https://codereview.chromium.org/2803673003
Cr-Commit-Position: refs/heads/master@{#462878}
Committed: https://chromium.googlesource.com/chromium/src/+/b06c0ba2c331d80d1b71fb8d2b2b581d389dead5

[mdjones, 2017-04-05 23:34:29]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2017-04-05 23:34:29]

Needed to pull a good ol' switcharoo...

[gone, 2017-04-06 00:37:10]

lgtm

[mdjones, 2017-04-06 21:29:28]

Description was changed from

==========
[Home] Fix status bar color on tab mode switch

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

BUG=708680
==========

to

==========
[Home] Fix status bar color on tab mode switch

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

This change also adds a special case for the incognito NTP, since
that page is completely dark, that status bar should be too.

BUG=708680
==========

[mdjones, 2017-04-06 21:29:47]

ptal again

[gone, 2017-04-06 21:32:29]

still lgtm but explain why in the comment

https://codereview.chromium.org/2803673003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2803673003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1842:
// If Chrome Home is enabled, the super of this function is not called.
why?

[mdjones, 2017-04-07 15:31:17]

https://codereview.chromium.org/2803673003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2803673003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1842:
// If Chrome Home is enabled, the super of this function is not called.
On 2017/04/06 21:32:29, dfalcantara (load balance plz) wrote:
> why?

Done.

[mdjones, 2017-04-07 15:31:25]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-04-07 15:31:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2803673003/#ps40001
(title: "explanation")

[commit-bot: I haz the power, 2017-04-07 15:31:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:08:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491579085491220,
"parent_rev": "67962d07466850c50a3e441d25b0fb6eeac05724", "commit_rev":
"b06c0ba2c331d80d1b71fb8d2b2b581d389dead5"}

[commit-bot: I haz the power, 2017-04-07 16:09:17]

Description was changed from

==========
[Home] Fix status bar color on tab mode switch

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

This change also adds a special case for the incognito NTP, since
that page is completely dark, that status bar should be too.

BUG=708680
==========

to

==========
[Home] Fix status bar color on tab mode switch

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

This change also adds a special case for the incognito NTP, since
that page is completely dark, that status bar should be too.

BUG=708680

Review-Url: https://codereview.chromium.org/2803673003
Cr-Commit-Position: refs/heads/master@{#462878}
Committed:
https://chromium.googlesource.com/chromium/src/+/b06c0ba2c331d80d1b71fb8d2b2b...
==========

[commit-bot: I haz the power, 2017-04-07 16:09:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b06c0ba2c331d80d1b71fb8d2b2b...