Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2922)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2803673003: [Home] Fix status bar color on tab mode switch (Closed)
Patch Set: explanation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 37fb5dde1b53b725b8f74b225e01a01428ac7db2..4303f547665a071de88e1ba6881de7adb0d48c20 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -1838,6 +1838,22 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
@Override
protected void setStatusBarColor(Tab tab, int color) {
if (DeviceFormFactor.isTablet(getApplicationContext())) return;
+
+ // If Chrome Home is enabled, the super of this function is not called because it only
+ // performs unnecessary transformations on the theme color.
+ if (getBottomSheet() != null) {
+ color = ApiCompatibilityUtils.getColor(getResources(), R.color.default_primary_color);
+ getBottomSheet().setSystemUiVisibility(View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR);
+
+ // Special case the incognito NTP and the tab switcher.
+ if ((tab != null && NewTabPage.isNTPUrl(tab.getUrl()) && tab.isIncognito())
+ || isInOverviewMode()) {
+ color = Color.BLACK;
+ }
+ ApiCompatibilityUtils.setStatusBarColor(getWindow(), color);
+ return;
+ }
+
super.setStatusBarColor(tab, isInOverviewMode() ? Color.BLACK : color);
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698