Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2803643002: [ios] Fix ChromeWebView framework umbrella header. (Closed)

Created:
3 years, 8 months ago by sdefresne
Modified:
3 years, 8 months ago
Reviewers:
gambard
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fix ChromeWebView framework umbrella header. No file named cwv_delegate.h exists in the ChromeWebView framework so remove it from the files #imported by the umbrella header. This will fix the compilation of code using the framework. The file was removed by https://codereview.chromium.org/2800433002 but not removed from the umbrella header, causing compilation failure after clobber or on pristine checkouts. BUG=None Review-Url: https://codereview.chromium.org/2803643002 Cr-Commit-Position: refs/heads/master@{#462036} Committed: https://chromium.googlesource.com/chromium/src/+/0421949d90d41a5d6121980ad89b55182a8acb5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ios/web_view/public/ChromeWebView.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
sdefresne
Please take a look.
3 years, 8 months ago (2017-04-05 11:38:40 UTC) #4
gambard
lgtm
3 years, 8 months ago (2017-04-05 11:39:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803643002/1
3 years, 8 months ago (2017-04-05 11:40:26 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 11:48:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0421949d90d41a5d6121980ad89b...

Powered by Google App Engine
This is Rietveld 408576698