Remove CWVDelegate.

Remove CWVDelegate.

BUG=703359
Review-Url: https://codereview.chromium.org/2800433002
Cr-Commit-Position: refs/heads/master@{#461910}
Committed: https://chromium.googlesource.com/chromium/src/+/8cb7e8847ef119d5b997c9d9964457c69b622adb

[michaeldo, 2017-04-04 18:28:09]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-04 18:34:39]

lgtm

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_client.h (right):

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_client.h:20: explicit
WebViewWebClient(std::string user_agent_product);
const std::string&

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_main_delegate.h (right):

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_main_delegate.h:20: explicit
WebViewWebMainDelegate(std::string user_agent_product);
ditto

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/public/cwv.h
File ios/web_view/public/cwv.h (right):

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/public/cwv.h#n...
ios/web_view/public/cwv.h:20: +
(void)configureWithUserAgentProductName:(NSString*)productName;
Please explain |productName| argument in the comments.

[michaeldo, 2017-04-04 21:24:28]

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_client.h (right):

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_client.h:20: explicit
WebViewWebClient(std::string user_agent_product);
On 2017/04/04 18:34:38, Eugene But wrote:
> const std::string&

Done.

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_main_delegate.h (right):

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_main_delegate.h:20: explicit
WebViewWebMainDelegate(std::string user_agent_product);
On 2017/04/04 18:34:38, Eugene But wrote:
> ditto

Done.

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/public/cwv.h
File ios/web_view/public/cwv.h (right):

https://codereview.chromium.org/2800433002/diff/1/ios/web_view/public/cwv.h#n...
ios/web_view/public/cwv.h:20: +
(void)configureWithUserAgentProductName:(NSString*)productName;
On 2017/04/04 18:34:39, Eugene But wrote:
> Please explain |productName| argument in the comments.

Done.

[michaeldo, 2017-04-04 21:24:36]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-04-04 21:24:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2800433002/#ps20001
(title: "Respond to comments.")

[commit-bot: I haz the power, 2017-04-04 21:25:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:17:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491341076569890,
"parent_rev": "131f7de1b67282e70b34c8281601e099a30101ba", "commit_rev":
"8cb7e8847ef119d5b997c9d9964457c69b622adb"}

[commit-bot: I haz the power, 2017-04-05 00:19:36]

Description was changed from

==========
Remove CWVDelegate.

BUG=703359
==========

to

==========
Remove CWVDelegate.

BUG=703359

Review-Url: https://codereview.chromium.org/2800433002
Cr-Commit-Position: refs/heads/master@{#461910}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cb7e8847ef119d5b997c9d99644...
==========

[commit-bot: I haz the power, 2017-04-05 00:19:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8cb7e8847ef119d5b997c9d99644...

[sdefresne, 2017-04-05 11:41:36]

On 2017/04/05 00:19:37, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/8cb7e8847ef119d5b997c9d99644...

This CL caused compilation failure of code depending on ChromeWebView framework
after a clobber as the file cwv_delegate.h was still referenced by
ChromeWebView.h. Fixed by https://codereview.chromium.org/2803643002/.


See
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
for an example of failure.