Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2803593003: Delay deleting profile notification (Closed)

Created:
3 years, 8 months ago by oshima
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay deleting profile notification BUG=703113 TEST=create html notification, exit browser, wait until notification closes and/or close notification. Review-Url: https://codereview.chromium.org/2803593003 Cr-Commit-Position: refs/heads/master@{#463377} Committed: https://chromium.googlesource.com/chromium/src/+/7f44763d0280f85ef331e31f2ea9dd93b3bf6ed3

Patch Set 1 : . #

Patch Set 2 : updated comment #

Total comments: 4

Patch Set 3 : addressed comments #

Patch Set 4 : fix hats test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 2 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 2 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
oshima
3 years, 8 months ago (2017-04-07 20:02:59 UTC) #11
stevenjb
lgtm https://codereview.chromium.org/2803593003/diff/40001/chrome/browser/notifications/message_center_notification_manager.cc File chrome/browser/notifications/message_center_notification_manager.cc (right): https://codereview.chromium.org/2803593003/diff/40001/chrome/browser/notifications/message_center_notification_manager.cc#newcode346 chrome/browser/notifications/message_center_notification_manager.cc:346: LOG(ERROR) << "******* DELETE SOON!"; I'm OK with ...
3 years, 8 months ago (2017-04-07 20:16:23 UTC) #12
oshima
https://codereview.chromium.org/2803593003/diff/40001/chrome/browser/notifications/message_center_notification_manager.cc File chrome/browser/notifications/message_center_notification_manager.cc (right): https://codereview.chromium.org/2803593003/diff/40001/chrome/browser/notifications/message_center_notification_manager.cc#newcode346 chrome/browser/notifications/message_center_notification_manager.cc:346: LOG(ERROR) << "******* DELETE SOON!"; On 2017/04/07 20:16:22, stevenjb ...
3 years, 8 months ago (2017-04-07 20:23:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803593003/60001
3 years, 8 months ago (2017-04-07 20:23:56 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/357757)
3 years, 8 months ago (2017-04-07 21:27:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803593003/80001
3 years, 8 months ago (2017-04-10 19:14:41 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:05:52 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7f44763d0280f85ef331e31f2ea9...

Powered by Google App Engine
This is Rietveld 408576698