Delay deleting profile notification

chrome/browser/notifications/message_center_notifications_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/keep_alive_registry.h"
 #include "chrome/browser/lifetime/keep_alive_types.h"
 #include "chrome/browser/notifications/message_center_notification_manager.h"
 #include "chrome/browser/notifications/notification.h"
@@ skipping 173 matching lines @@
   delegate->Release();
   delegate2->Release();
 }
 
 IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest, VerifyKeepAlives) {
   EXPECT_FALSE(KeepAliveRegistry::GetInstance()->IsOriginRegistered(
       KeepAliveOrigin::NOTIFICATION));
 
   TestDelegate* delegate;
   manager()->Add(CreateTestNotification("a", &delegate), profile());
+  {
+    base::RunLoop loop;
+    loop.RunUntilIdle();
+  }

[stevenjb, 2017/04/07 20:16:23]

nit: These could but put in a helper method, e.g. RunLoopUntilIdle().

[oshima, 2017/04/07 20:23:01]

Done.

   EXPECT_TRUE(KeepAliveRegistry::GetInstance()->IsOriginRegistered(
       KeepAliveOrigin::NOTIFICATION));
 
   TestDelegate* delegate2;
   manager()->Add(CreateRichTestNotification("b", &delegate2), profile());
+  {
+    base::RunLoop loop;
+    loop.RunUntilIdle();
+  }
   EXPECT_TRUE(KeepAliveRegistry::GetInstance()->IsOriginRegistered(
       KeepAliveOrigin::NOTIFICATION));
 
   manager()->CancelById("a", NotificationUIManager::GetProfileID(profile()));
+  {
+    base::RunLoop loop;
+    loop.RunUntilIdle();
+  }
   EXPECT_TRUE(KeepAliveRegistry::GetInstance()->IsOriginRegistered(
       KeepAliveOrigin::NOTIFICATION));
 
   manager()->CancelById("b", NotificationUIManager::GetProfileID(profile()));
+  {
+    base::RunLoop loop;
+    loop.RunUntilIdle();
+  }
   EXPECT_FALSE(KeepAliveRegistry::GetInstance()->IsOriginRegistered(
       KeepAliveOrigin::NOTIFICATION));
 
   delegate->Release();
   delegate2->Release();
 }
 
 // Notification center is only used on ChromeOS.
 #if defined(OS_CHROMEOS)
 
@@ skipping 206 matching lines @@
   EXPECT_EQ("", observer.log(notification_id));
 
   message_center()->SetVisibility(message_center::VISIBILITY_TRANSIENT);
   EXPECT_EQ(base::StringPrintf("update-%s", notification_id.c_str()),
             observer.log(notification_id));
 
   delegate->Release();
 }
 
 #endif  // defined(OS_CHROMEOS)