Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 2803583002: Rename PendingSelection to LayoutSelection (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PendingSelection to LayoutSelection This class controls whether LayoutObject.selectionState should be updated. However its name is ambiguous and we're going to let the class have more power to manage LayoutObject. Thus rename it. BUG=708453 Review-Url: https://codereview.chromium.org/2803583002 Cr-Commit-Position: refs/heads/master@{#462356} Committed: https://chromium.googlesource.com/chromium/src/+/9b622930a92d073c8a558ee00ff9fc14c90478c0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -250 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/LayoutSelection.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/core/editing/PendingSelection.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/core/editing/PendingSelection.cpp View 1 chunk +0 lines, -171 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yoichio
3 years, 8 months ago (2017-04-05 09:13:40 UTC) #7
yoichio
On 2017/04/05 09:13:40, yoichio wrote: PTAL
3 years, 8 months ago (2017-04-06 01:39:23 UTC) #8
yosin_UTC9
lgtm https://codereview.chromium.org/2803583002/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.h File third_party/WebKit/Source/core/editing/FrameSelection.h (right): https://codereview.chromium.org/2803583002/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.h#newcode294 third_party/WebKit/Source/core/editing/FrameSelection.h:294: const Member<LayoutSelection> m_pendingSelection; I expect following patch will ...
3 years, 8 months ago (2017-04-06 04:21:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803583002/1
3 years, 8 months ago (2017-04-06 04:22:19 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 04:30:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b622930a92d073c8a558ee00ff9...

Powered by Google App Engine
This is Rietveld 408576698