Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2803493002: Revert of [Chromecast][Temporary] Disable TCMallocTest.Realloc on cast audio. (Closed)

Created:
3 years, 8 months ago by bcf
Modified:
3 years, 8 months ago
Reviewers:
slan, mbjorge
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, jonathanve_google.com, lcwu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast][Temporary] Disable TCMallocTest.Realloc on cast audio. (patchset #1 id:1 of https://codereview.chromium.org/2748303002/ ) Reason for revert: Failing test has been made less aggressive for low memory devices: https://codereview.chromium.org/2790173004/ Original issue's description: > [Chromecast][Temporary] Disable TCMallocTest.Realloc on cast audio. > > In an effort to get a useful/clean signal from the cast unittest system, > the current failing tests are being disabled to get the system back to a > green state. The disabled tests will be vigilantly monitored by mbjorge@ > and jonathanve@ to ensure they are fixed and not forgotten. > > Tracking hostlist: 461351 > > BUG=internal b/36238217 > > Review-Url: https://codereview.chromium.org/2748303002 > Cr-Commit-Position: refs/heads/master@{#457815} > Committed: https://chromium.googlesource.com/chromium/src/+/8a00591ff93138eeff480aa0e860b92db580e903 TBR=slan@chromium.org,mbjorge@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=internal b/36238217 Review-Url: https://codereview.chromium.org/2803493002 Cr-Commit-Position: refs/heads/master@{#462306} Committed: https://chromium.googlesource.com/chromium/src/+/a50add13270f546d2e003866f2914fa232a098b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chromecast/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bcf
Created Revert of [Chromecast][Temporary] Disable TCMallocTest.Realloc on cast audio.
3 years, 8 months ago (2017-04-04 22:39:21 UTC) #1
mbjorge
lgtm
3 years, 8 months ago (2017-04-04 22:48:53 UTC) #6
slan
lgtm
3 years, 8 months ago (2017-04-05 21:34:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803493002/1
3 years, 8 months ago (2017-04-05 23:28:26 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 01:12:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a50add13270f546d2e003866f291...

Powered by Google App Engine
This is Rietveld 408576698