Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2748303002: [Chromecast][Temporary] Disable TCMallocTest.Realloc on cast audio. (Closed)

Created:
3 years, 9 months ago by mbjorge
Modified:
3 years, 9 months ago
Reviewers:
slan
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org, jonathanve_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast][Temporary] Disable TCMallocTest.Realloc on cast audio. In an effort to get a useful/clean signal from the cast unittest system, the current failing tests are being disabled to get the system back to a green state. The disabled tests will be vigilantly monitored by mbjorge@ and jonathanve@ to ensure they are fixed and not forgotten. Tracking hostlist: 461351 BUG=internal b/36238217 Review-Url: https://codereview.chromium.org/2748303002 Cr-Commit-Position: refs/heads/master@{#457815} Committed: https://chromium.googlesource.com/chromium/src/+/8a00591ff93138eeff480aa0e860b92db580e903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chromecast/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mbjorge
3 years, 9 months ago (2017-03-15 16:18:37 UTC) #2
slan
lgtm
3 years, 9 months ago (2017-03-15 22:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748303002/1
3 years, 9 months ago (2017-03-17 16:19:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8a00591ff93138eeff480aa0e860b92db580e903
3 years, 9 months ago (2017-03-17 18:13:17 UTC) #8
bcf
3 years, 8 months ago (2017-04-04 22:39:21 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2803493002/ by bcf@chromium.org.

The reason for reverting is: Failing test has been made less aggressive for low
memory devices:
https://codereview.chromium.org/2790173004/.

Powered by Google App Engine
This is Rietveld 408576698