Use a ResizeObserver to determine default font-size for text tracks

Use a ResizeObserver to determine default font-size for text tracks

Text track needs to derive the default font for the cues from the size
of the <video> area, and currently does this by updating style during
the call to layout() on the LayoutTextTrackContainer, violating the
document lifecycle.

To avoid mutating style during layout, hook up a ResizeObserver from
TextTrackContainer to HTMLVideoElement and rely on the ResizeObserver
logic to iterate on the style and layout.

This eliminates the need to have a special LayoutObject for
TextTrackContainer, so just use a LayoutBlockFlow and remove all traces
of LayoutTextTrackContainer.

The media/track/track-cue-rendering.html test is updated to check sizes
after layout and paint instead of a forced layout.

BUG=372245
Review-Url: https://codereview.chromium.org/2803243002
Cr-Commit-Position: refs/heads/master@{#463280}
Committed: https://chromium.googlesource.com/chromium/src/+/8b2491697f386b054dd28549f0c66d717f020d0d

[fs, 2017-04-07 12:14:15]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 12:14:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 13:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:32:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fs, 2017-04-07 14:14:32]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 14:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-07 14:17:05]

Description was changed from

==========
Use a ResizeObserver to determine default font-size for text tracks

Text track needs to derive the default font for the cues from the size
of the <video> area, and currently does this by updating style during
the call to layout() on the LayoutTextTrackContainer, violating the
document lifecycle.

To avoid mutating style during layout, hook up a ResizeObserver from
TextTrackContainer to HTMLVideoElement and rely on the ResizeObserver
logic to iterate on the style and layout.

This eliminates the need to have a special LayoutObject for
TextTrackContainer, so just use a LayoutBlockFlow and remove all traces
of LayoutTextTrackContainer.

BUG=372245
==========

to

==========
Use a ResizeObserver to determine default font-size for text tracks

Text track needs to derive the default font for the cues from the size
of the <video> area, and currently does this by updating style during
the call to layout() on the LayoutTextTrackContainer, violating the
document lifecycle.

To avoid mutating style during layout, hook up a ResizeObserver from
TextTrackContainer to HTMLVideoElement and rely on the ResizeObserver
logic to iterate on the style and layout.

This eliminates the need to have a special LayoutObject for
TextTrackContainer, so just use a LayoutBlockFlow and remove all traces
of LayoutTextTrackContainer.

The media/track/track-cue-rendering.html test is updated to check sizes
after layout and paint instead of a forced layout.

BUG=372245
==========

[fs, 2017-04-07 15:25:19]

fs@opera.com changed reviewers:
+ atotic@chromium.org, esprehn@chromium.org

[commit-bot: I haz the power, 2017-04-07 15:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 15:42:55]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-04-08 12:57:56]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-04-08 12:57:57]

Very excited to see ResizeObserver being used like that :) FWIW, the media
controls code did something similar to also reduce dependency with LayoutMedia.

non-owner lgtm :)

https://codereview.chromium.org/2803243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp (right):

https://codereview.chromium.org/2803243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp:65: }
style: leave empty line before end of namespace and add a end of namespace
comment (// anonymous namespace).

[atotic, 2017-04-09 05:08:08]

lgtm

great to see ResizeObserver used. Need to ship it to webdevs soon.

[fs, 2017-04-10 13:34:38]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-10 13:36:27]

https://codereview.chromium.org/2803243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp (right):

https://codereview.chromium.org/2803243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp:65: }
On 2017/04/08 at 12:57:57, mlamouri wrote:
> style: leave empty line before end of namespace and add a end of namespace
comment (// anonymous namespace).

Done.

[commit-bot: I haz the power, 2017-04-10 15:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:39:03]

Dry run: This issue passed the CQ dry run.

[fs, 2017-04-10 15:39:37]

The CQ bit was checked by fs@opera.com

[fs, 2017-04-10 15:39:37]

The patchset sent to the CQ was uploaded after l-g-t-m from atotic@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2803243002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-10 15:40:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:51:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491838777483780,
"parent_rev": "c9eee7b151df9f93a92b29100680ab80f1c06a3b", "commit_rev":
"8b2491697f386b054dd28549f0c66d717f020d0d"}

[commit-bot: I haz the power, 2017-04-10 15:52:03]

Description was changed from

==========
Use a ResizeObserver to determine default font-size for text tracks

Text track needs to derive the default font for the cues from the size
of the <video> area, and currently does this by updating style during
the call to layout() on the LayoutTextTrackContainer, violating the
document lifecycle.

To avoid mutating style during layout, hook up a ResizeObserver from
TextTrackContainer to HTMLVideoElement and rely on the ResizeObserver
logic to iterate on the style and layout.

This eliminates the need to have a special LayoutObject for
TextTrackContainer, so just use a LayoutBlockFlow and remove all traces
of LayoutTextTrackContainer.

The media/track/track-cue-rendering.html test is updated to check sizes
after layout and paint instead of a forced layout.

BUG=372245
==========

to

==========
Use a ResizeObserver to determine default font-size for text tracks

Text track needs to derive the default font for the cues from the size
of the <video> area, and currently does this by updating style during
the call to layout() on the LayoutTextTrackContainer, violating the
document lifecycle.

To avoid mutating style during layout, hook up a ResizeObserver from
TextTrackContainer to HTMLVideoElement and rely on the ResizeObserver
logic to iterate on the style and layout.

This eliminates the need to have a special LayoutObject for
TextTrackContainer, so just use a LayoutBlockFlow and remove all traces
of LayoutTextTrackContainer.

The media/track/track-cue-rendering.html test is updated to check sizes
after layout and paint instead of a forced layout.

BUG=372245

Review-Url: https://codereview.chromium.org/2803243002
Cr-Commit-Position: refs/heads/master@{#463280}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b2491697f386b054dd28549f0c6...
==========

[commit-bot: I haz the power, 2017-04-10 15:52:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8b2491697f386b054dd28549f0c6...

[dglazkov, 2017-04-10 15:54:40]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-04-10 15:54:40]

lgtm

[yosin_UTC9, 2017-04-11 05:56:51]

On 2017/04/10 at 13:36:27, fs wrote:
>
https://codereview.chromium.org/2803243002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp (right):
> 
>
https://codereview.chromium.org/2803243002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp:65: }
> On 2017/04/08 at 12:57:57, mlamouri wrote:
> > style: leave empty line before end of namespace and add a end of namespace
comment (// anonymous namespace).
> 
> Done.

I really appreciate for you fixing this!
This issue blocked making editing fast.
You did it! (^_^)b