Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp

Issue 2803243002: Use a ResizeObserver to determine default font-size for text tracks (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc.
4 * All rights reserved.
5 *
6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions
8 * are met:
9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer.
11 * 2. Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 *
15 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
16 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
17 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
18 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
19 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
20 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
22 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
23 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
24 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
25 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */
27
28 #include "core/layout/LayoutTextTrackContainer.h"
29
30 #include "core/frame/DeprecatedScheduleStyleRecalcDuringLayout.h"
31 #include "core/layout/LayoutVideo.h"
32
33 namespace blink {
34
35 LayoutTextTrackContainer::LayoutTextTrackContainer(Element* element)
36 : LayoutBlockFlow(element), font_size_(0) {}
37
38 void LayoutTextTrackContainer::GetLayout() {
39 LayoutBlockFlow::GetLayout();
40 if (Style()->Display() == EDisplay::kNone)
41 return;
42
43 DeprecatedScheduleStyleRecalcDuringLayout marker(
44 GetNode()->GetDocument().Lifecycle());
45
46 LayoutObject* media_layout_object = Parent();
47 if (!media_layout_object || !media_layout_object->IsVideo())
48 return;
49 if (UpdateSizes(ToLayoutVideo(*media_layout_object)))
50 ToElement(GetNode())->SetInlineStyleProperty(
51 CSSPropertyFontSize, font_size_, CSSPrimitiveValue::UnitType::kPixels);
52 }
53
54 bool LayoutTextTrackContainer::UpdateSizes(
55 const LayoutVideo& video_layout_object) {
56 // FIXME: The video size is used to calculate the font size (a workaround
57 // for lack of per-spec vh/vw support) but the whole media element is used
58 // for cue rendering. This is inconsistent. See also the somewhat related
59 // spec bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28105
60 LayoutSize video_size = video_layout_object.ReplacedContentRect().size();
61
62 float smallest_dimension =
63 std::min(video_size.Height().ToFloat(), video_size.Width().ToFloat());
64
65 float font_size = smallest_dimension * 0.05f;
66
67 // Avoid excessive FP precision issue.
68 // C11 5.2.4.2.2:9 requires assignment and cast to remove extra precision, but
69 // the behavior is currently not portable. fontSize may have precision higher
70 // than m_fontSize thus straight comparison can fail despite they cast to the
71 // same float value.
72 volatile float& current_font_size = font_size_;
73 float old_font_size = current_font_size;
74 current_font_size = font_size;
75 return current_font_size != old_font_size;
76 }
77
78 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698