Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2803163003: Delete RenderFrameHostImpl::SetHasReceivedUserGesture. (Closed)

Created:
3 years, 8 months ago by vasilii
Modified:
3 years, 8 months ago
Reviewers:
Nate Chapin, alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete RenderFrameHostImpl::SetHasReceivedUserGesture. The method is unused. It was introduced in https://codereview.chromium.org/2445193005. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2803163003 Cr-Commit-Position: refs/heads/master@{#463374} Committed: https://chromium.googlesource.com/chromium/src/+/da3893d557d59f6286ab55c92a07608772c03347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
vasilii
Hi Nate, please review.
3 years, 8 months ago (2017-04-07 10:46:59 UTC) #6
vasilii
Hi Alex, please review.
3 years, 8 months ago (2017-04-10 09:39:09 UTC) #10
Nate Chapin
LGTM, but I'm not an owner.
3 years, 8 months ago (2017-04-10 17:04:25 UTC) #11
alexmos
LGTM
3 years, 8 months ago (2017-04-10 17:10:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803163003/1
3 years, 8 months ago (2017-04-10 17:11:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/153947)
3 years, 8 months ago (2017-04-10 19:14:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803163003/1
3 years, 8 months ago (2017-04-10 19:16:06 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:56:55 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da3893d557d59f6286ab55c92a07...

Powered by Google App Engine
This is Rietveld 408576698