Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 2445193005: Route setHasReceivedUserGesture() state for RemoteFrames (Closed)

Created:
4 years, 1 month ago by Nate Chapin
Modified:
4 years, 1 month ago
Reviewers:
nasko, ojan
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, jam, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route setHasReceivedUserGesture() state for RemoteFrames This also removes the ability to clear Document::m_hasReceivedUserGesture, which was only used for an experiment that is behind a flag and probably shouldn't be using it anyway. BUG=658800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/74e6d69671055f435029efa126168f4370cb5d5b Cr-Commit-Position: refs/heads/master@{#427893}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -26 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +4 lines, -0 lines 1 comment Download
M content/browser/frame_host/render_frame_proxy_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentUserGestureToken.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp View 1 chunk +23 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrameClient.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Nate Chapin
ojan: PTAL at core/ (esp. FrameLoader.cpp, which changes the history user gesture experiment to allow ...
4 years, 1 month ago (2016-10-26 21:20:22 UTC) #14
nasko
content/ and IPC message routing LGTM. https://codereview.chromium.org/2445193005/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/2445193005/diff/1/content/browser/frame_host/render_frame_host_impl.cc#newcode2732 content/browser/frame_host/render_frame_host_impl.cc:2732: Send(new FrameMsg_SetHasReceivedUserGesture(GetRoutingID())); nit: ...
4 years, 1 month ago (2016-10-26 22:17:23 UTC) #15
ojan
lgtm
4 years, 1 month ago (2016-10-26 23:02:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445193005/1
4 years, 1 month ago (2016-10-26 23:08:19 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 00:45:39 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 00:48:00 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74e6d69671055f435029efa126168f4370cb5d5b
Cr-Commit-Position: refs/heads/master@{#427893}

Powered by Google App Engine
This is Rietveld 408576698