Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2803093003: Multicol block should be processed by Legacy Layout engine. (Closed)

Created:
3 years, 8 months ago by Gleb Lanbin
Modified:
3 years, 8 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Multicol block should be processed by Legacy Layout engine. For the 1st phase of LayoutNG's multicol implementation we want to utilize the existing ColumnBalancer class. That's why multicol blocks need to processed by Legacy Layout engine. This patch also fixes some DCHECK(NOT_IMPLEMENTED) crashes. BUG=635619 Review-Url: https://codereview.chromium.org/2803093003 Cr-Commit-Position: refs/heads/master@{#462677} Committed: https://chromium.googlesource.com/chromium/src/+/58f84757e7003f5dcb3740d29227c02c84622162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Gleb Lanbin
3 years, 8 months ago (2017-04-06 20:45:50 UTC) #3
ikilpatrick
lgtm
3 years, 8 months ago (2017-04-06 20:58:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803093003/1
3 years, 8 months ago (2017-04-06 23:16:23 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:26:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58f84757e7003f5dcb3740d29227...

Powered by Google App Engine
This is Rietveld 408576698