Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2803093003: Multicol block should be processed by Legacy Layout engine. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index 088d892106717c0c9b99d662aaa6d44649ad1406..f3aeb4d96075ebd4fe77994b60f81c5b5c7c178c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -238,6 +238,12 @@ DEFINE_TRACE(NGBlockNode) {
}
bool NGBlockNode::CanUseNewLayout() {
+ // [Multicol]: for the 1st phase of LayoutNG's multicol implementation we want
+ // to utilize the existing ColumnBalancer class. That's why a multicol block
+ // should be processed by Legacy Layout engine.
+ if (Style().specifiesColumns())
+ return false;
+
if (!layout_box_->isLayoutBlockFlow())
return false;
return RuntimeEnabledFeatures::layoutNGEnabled() || !HasInlineChildren();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698