Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2803013003: Revert of resource_sizes.py: Fix typo causing BuildId to not actually verify (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of resource_sizes.py: Fix typo causing BuildId to not actually verify (patchset #1 id:1 of https://codereview.chromium.org/2799743002/ ) Reason for revert: Breaks 64-bit monochrome / webview (uncovered a bug) Original issue's description: > resource_sizes.py: Fix typo causing BuildId to not actually verify > > Review-Url: https://codereview.chromium.org/2799743002 > Cr-Commit-Position: refs/heads/master@{#462284} > Committed: https://chromium.googlesource.com/chromium/src/+/21e4391b8b8f91da2b4fe626aacb64e78667591e TBR=estevenson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2803013003 Cr-Commit-Position: refs/heads/master@{#462463} Committed: https://chromium.googlesource.com/chromium/src/+/2400df3e07cbda738c7089f1f8a71ba9e19357c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/resource_sizes.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
agrieve
Created Revert of resource_sizes.py: Fix typo causing BuildId to not actually verify
3 years, 8 months ago (2017-04-06 14:27:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803013003/1
3 years, 8 months ago (2017-04-06 14:27:23 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 14:29:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2400df3e07cbda738c7089f1f8a7...

Powered by Google App Engine
This is Rietveld 408576698