Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2799743002: resource_sizes.py: Fix typo causing BuildId to not actually verify (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

resource_sizes.py: Fix typo causing BuildId to not actually verify Review-Url: https://codereview.chromium.org/2799743002 Cr-Commit-Position: refs/heads/master@{#462284} Committed: https://chromium.googlesource.com/chromium/src/+/21e4391b8b8f91da2b4fe626aacb64e78667591e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/resource_sizes.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
agrieve
On 2017/04/05 19:36:44, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org
3 years, 8 months ago (2017-04-05 19:36:47 UTC) #3
estevenson
lgtm, oops!
3 years, 8 months ago (2017-04-05 19:38:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799743002/1
3 years, 8 months ago (2017-04-05 23:57:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/21e4391b8b8f91da2b4fe626aacb64e78667591e
3 years, 8 months ago (2017-04-06 00:06:02 UTC) #12
agrieve
3 years, 8 months ago (2017-04-06 14:27:02 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2803013003/ by agrieve@chromium.org.

The reason for reverting is: Breaks 64-bit monochrome / webview (uncovered a
bug).

Powered by Google App Engine
This is Rietveld 408576698