Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2803013002: Revert of Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
alexmos, nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. (patchset #1 id:1 of https://codereview.chromium.org/2797753002/ ) Reason for revert: Test is flaky without PlzNavigate also: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54421 Original issue's description: > Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. > > These two tests were fully disabled due to flakiness. However, they > only flake with PlzNavigate enabled, so this CL enables them with the > current navigation code. > > BUG=708139 > > Review-Url: https://codereview.chromium.org/2797753002 > Cr-Commit-Position: refs/heads/master@{#461769} > Committed: https://chromium.googlesource.com/chromium/src/+/6d1a7f6758769bb73a40ff8b8d21aa3b580a4926 TBR=alexmos@chromium.org,nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=708139 Review-Url: https://codereview.chromium.org/2803013002 Cr-Commit-Position: refs/heads/master@{#462454} Committed: https://chromium.googlesource.com/chromium/src/+/17fc62872e411a7ab02f9f352763073e43d38916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Elly Fong-Jones
Created Revert of Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate.
3 years, 8 months ago (2017-04-06 13:20:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803013002/1
3 years, 8 months ago (2017-04-06 13:20:31 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 14:00:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17fc62872e411a7ab02f9f352763...

Powered by Google App Engine
This is Rietveld 408576698