Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2797753002: Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. (Closed)

Created:
3 years, 8 months ago by nasko
Modified:
3 years, 8 months ago
Reviewers:
alexmos
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. These two tests were fully disabled due to flakiness. However, they only flake with PlzNavigate enabled, so this CL enables them with the current navigation code. BUG=708139 Review-Url: https://codereview.chromium.org/2797753002 Cr-Commit-Position: refs/heads/master@{#461769} Committed: https://chromium.googlesource.com/chromium/src/+/6d1a7f6758769bb73a40ff8b8d21aa3b580a4926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
alexmos
LGTM
3 years, 8 months ago (2017-04-04 17:23:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797753002/1
3 years, 8 months ago (2017-04-04 17:24:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6d1a7f6758769bb73a40ff8b8d21aa3b580a4926
3 years, 8 months ago (2017-04-04 18:15:36 UTC) #7
Elly Fong-Jones
3 years, 8 months ago (2017-04-06 13:20:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2803013002/ by ellyjones@chromium.org.

The reason for reverting is: Test is flaky without PlzNavigate also:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/....

Powered by Google App Engine
This is Rietveld 408576698