Remove ScopedVector from chrome/

Remove ScopedVector from chrome/

base::ScopedVector is deprecated, see bug.

BUG=554289
Review-Url: https://codereview.chromium.org/2802973003
Cr-Commit-Position: refs/heads/master@{#463545}
Committed: https://chromium.googlesource.com/chromium/src/+/11c5ec813536507048ad1c54d04840a522fa5748

[leonhsl(Using Gerrit), 2017-04-07 08:18:23]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 08:18:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 09:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 09:06:36]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-07 09:10:50]

leon.han@intel.com changed reviewers:
+ avi@chromium.org, sky@chromium.org

[leonhsl(Using Gerrit), 2017-04-07 09:10:51]

PTAL, Thanks. This is the last CL for chrome/.

[sky, 2017-04-07 14:42:14]

https://codereview.chromium.org/2802973003/diff/1/chrome/service/service_ipc_...
File chrome/service/service_ipc_server.cc (right):

https://codereview.chromium.org/2802973003/diff/1/chrome/service/service_ipc_...
chrome/service/service_ipc_server.cc:95: std::vector<MessageHandler*>
temp_handlers(message_handlers_.size());
You've used a for loop for this functionality in other places, which is far
easier to read.

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
File chrome/utility/safe_browsing/mac/dmg_iterator.h (right):

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
chrome/utility/safe_browsing/mac/dmg_iterator.h:53: partitions_;            //
Streams for all the HFS partitions.
Move the comment the previous line to avoid the obscure line splitting.

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
File chrome/utility/safe_browsing/mac/udif.h (right):

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
chrome/utility/safe_browsing/mac/udif.h:80: blocks_;           // All blocks in
the UDIF image.
Move to previous line.

[Avi (use Gerrit), 2017-04-07 15:37:16]

lgtm with the issues that Scott pointed out addressed.

[leonhsl(Using Gerrit), 2017-04-10 08:14:20]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 08:14:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-10 08:33:06]

Uploaded ps#2 to address comments, PTAnL, Thanks.

https://codereview.chromium.org/2802973003/diff/1/chrome/service/service_ipc_...
File chrome/service/service_ipc_server.cc (right):

https://codereview.chromium.org/2802973003/diff/1/chrome/service/service_ipc_...
chrome/service/service_ipc_server.cc:95: std::vector<MessageHandler*>
temp_handlers(message_handlers_.size());
On 2017/04/07 14:42:14, sky wrote:
> You've used a for loop for this functionality in other places, which is far
> easier to read.

Done.
Sorry for this! I was writing such codes before 'other places'..

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
File chrome/utility/safe_browsing/mac/dmg_iterator.h (right):

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
chrome/utility/safe_browsing/mac/dmg_iterator.h:53: partitions_;            //
Streams for all the HFS partitions.
On 2017/04/07 14:42:14, sky wrote:
> Move the comment the previous line to avoid the obscure line splitting.

Done and thanks.

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
File chrome/utility/safe_browsing/mac/udif.h (right):

https://codereview.chromium.org/2802973003/diff/1/chrome/utility/safe_browsin...
chrome/utility/safe_browsing/mac/udif.h:80: blocks_;           // All blocks in
the UDIF image.
On 2017/04/07 14:42:14, sky wrote:
> Move to previous line.

Done.

[commit-bot: I haz the power, 2017-04-10 08:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 08:54:03]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-10 16:13:32]

LGTM

[leonhsl(Using Gerrit), 2017-04-11 05:32:47]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-04-11 05:32:48]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2802973003/#ps20001
(title: "Address comments from sky@")

[commit-bot: I haz the power, 2017-04-11 05:33:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 05:39:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491888767580080,
"parent_rev": "a69f79bc7c3c88035471592891d7d43735eacebb", "commit_rev":
"11c5ec813536507048ad1c54d04840a522fa5748"}

[commit-bot: I haz the power, 2017-04-11 05:40:35]

Description was changed from

==========
Remove ScopedVector from chrome/

base::ScopedVector is deprecated, see bug.

BUG=554289
==========

to

==========
Remove ScopedVector from chrome/

base::ScopedVector is deprecated, see bug.

BUG=554289

Review-Url: https://codereview.chromium.org/2802973003
Cr-Commit-Position: refs/heads/master@{#463545}
Committed:
https://chromium.googlesource.com/chromium/src/+/11c5ec813536507048ad1c54d048...
==========

[commit-bot: I haz the power, 2017-04-11 05:40:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/11c5ec813536507048ad1c54d048...