Remove ScopedVector from chrome/

chrome/service/service_ipc_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/service_ipc_server.h"
 
+#include <algorithm>
+
 #include "base/metrics/histogram_delta_serialization.h"
 #include "build/build_config.h"
 #include "chrome/common/service_messages.h"
 #include "ipc/ipc_channel_mojo.h"
 #include "ipc/ipc_logging.h"
 
 ServiceIPCServer::ServiceIPCServer(
     Client* client,
     const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
     base::WaitableEvent* shutdown_event)
@@ skipping 51 matching lines @@
   if (!channel_.get()) {
     delete msg;
     return false;
   }
 
   return channel_->Send(msg);
 }
 
 void ServiceIPCServer::AddMessageHandler(
     std::unique_ptr<MessageHandler> handler) {
-  message_handlers_.push_back(handler.release());
+  message_handlers_.push_back(std::move(handler));
 }
 
 bool ServiceIPCServer::OnMessageReceived(const IPC::Message& msg) {
   DCHECK(ipc_client_connected_);
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ServiceIPCServer, msg)
     IPC_MESSAGE_HANDLER(ServiceMsg_GetHistograms, OnGetHistograms)
     IPC_MESSAGE_HANDLER(ServiceMsg_Shutdown, OnShutdown);
     IPC_MESSAGE_HANDLER(ServiceMsg_UpdateAvailable, OnUpdateAvailable);
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   if (!handled) {
     // Make a copy of the handlers to prevent modification during iteration.
-    std::vector<MessageHandler*> temp_handlers = message_handlers_.get();
+    std::vector<MessageHandler*> temp_handlers(message_handlers_.size());

[sky, 2017/04/07 14:42:14]

You've used a for loop for this functionality in other places, which is far
easier to read.

[leonhsl(Using Gerrit), 2017/04/10 08:33:06]

Done.
Sorry for this! I was writing such codes before 'other places'..

+    std::transform(
+        message_handlers_.cbegin(), message_handlers_.cend(),
+        temp_handlers.begin(),
+        [](const std::unique_ptr<MessageHandler>& item) { return item.get(); });
     for (auto* handler : temp_handlers) {
       handled = handler->HandleMessage(msg);
       if (handled)
         break;
     }
   }
 
   return handled;
 }
 
@@ skipping 10 matching lines @@
   channel_->Send(new ServiceHostMsg_Histograms(deltas));
 }
 
 void ServiceIPCServer::OnShutdown() {
   client_->OnShutdown();
 }
 
 void ServiceIPCServer::OnUpdateAvailable() {
   client_->OnUpdateAvailable();
 }