Add gn args to metadata and metadata diffing

Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

NOTRY=true
BUG=681694
Review-Url: https://codereview.chromium.org/2802893002
Cr-Commit-Position: refs/heads/master@{#462559}
Committed: https://chromium.googlesource.com/chromium/src/+/ca8dfa51db7ed68b7c8fca1ebc168539349a9675

[agrieve, 2017-04-06 01:31:14]

Description was changed from

==========
Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

BUG=681694
==========

to

==========
Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

BUG=681694
==========

[agrieve, 2017-04-06 01:31:14]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-04-06 01:31:31]

On 2017/04/06 01:31:14, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🚙

[estevenson, 2017-04-06 17:02:15]

lgtm, forgot to send this one. Good call adding gn args to metadata!

[agrieve, 2017-04-06 18:02:05]

Description was changed from

==========
Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

BUG=681694
==========

to

==========
Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

NOTRY=true
BUG=681694
==========

[agrieve, 2017-04-06 18:20:55]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:44:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491502855856340, "parent_rev":
"be1231cfb2e3a3f4a36df294a72acd888c45fc0e", "commit_rev":
"ca8dfa51db7ed68b7c8fca1ebc168539349a9675"}

[commit-bot: I haz the power, 2017-04-06 18:45:41]

Description was changed from

==========
Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

NOTRY=true
BUG=681694
==========

to

==========
Add gn args to metadata and metadata diffing

When diffing, should help confirm we're comparing apples to apples.
When just analyzing. Validating that the correct gn args were used as
actually quite important, so they are worth recording.

NOTRY=true
BUG=681694

Review-Url: https://codereview.chromium.org/2802893002
Cr-Commit-Position: refs/heads/master@{#462559}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca8dfa51db7ed68b7c8fca1ebc16...
==========

[commit-bot: I haz the power, 2017-04-06 18:45:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca8dfa51db7ed68b7c8fca1ebc16...