//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

NOTRY=true
BUG=681694
Review-Url: https://codereview.chromium.org/2801663003
Cr-Commit-Position: refs/heads/master@{#462474}
Committed: https://chromium.googlesource.com/chromium/src/+/2ed07a74b39aa94480fe5618c9cc787bec66dd34

[agrieve, 2017-04-05 19:00:29]

Description was changed from

==========
//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

BUG=681694
==========

to

==========
//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

BUG=681694
==========

[agrieve, 2017-04-05 19:00:29]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-04-05 19:00:43]

On 2017/04/05 19:00:29, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🚕

[estevenson, 2017-04-06 14:14:01]

lgtm

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/map2size.py
File tools/binary_size/map2size.py (right):

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/map2size....
tools/binary_size/map2size.py:229: # Verify tool_prefix early.
nit: remove this comment?

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/map2size....
tools/binary_size/map2size.py:327: def relative_to_out(path):
Is this the preferred naming convention for inner functions? I've seen this and
camel case both use frequently and I never know which to choose.

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/models.py
File tools/binary_size/models.py (right):

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/models.py...
tools/binary_size/models.py:23: P---A------S
?

[agrieve, 2017-04-06 14:53:54]

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/map2size.py
File tools/binary_size/map2size.py (right):

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/map2size....
tools/binary_size/map2size.py:229: # Verify tool_prefix early.
On 2017/04/06 14:14:01, estevenson wrote:
> nit: remove this comment?

Done.

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/map2size....
tools/binary_size/map2size.py:327: def relative_to_out(path):
On 2017/04/06 14:14:01, estevenson wrote:
> Is this the preferred naming convention for inner functions? I've seen this
and
> camel case both use frequently and I never know which to choose.

I believe so. I say this only because that's what John told me to use at one
point.

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/models.py
File tools/binary_size/models.py (right):

https://codereview.chromium.org/2801663003/diff/1/tools/binary_size/models.py...
tools/binary_size/models.py:23: P---A------S
On 2017/04/06 14:14:01, estevenson wrote:
> ?

Whoops :P. Removed.

[agrieve, 2017-04-06 14:55:30]

Description was changed from

==========
//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

BUG=681694
==========

to

==========
//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

NOTRY=true
BUG=681694
==========

[agrieve, 2017-04-06 14:55:36]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-04-06 14:55:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2801663003/#ps20001
(title: "Review comments")

[commit-bot: I haz the power, 2017-04-06 14:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 15:00:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491490536396910,
"parent_rev": "f7080b8d0e906ba0a0bb13411597645233a56a99", "commit_rev":
"2ed07a74b39aa94480fe5618c9cc787bec66dd34"}

[commit-bot: I haz the power, 2017-04-06 15:01:30]

Description was changed from

==========
//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

NOTRY=true
BUG=681694
==========

to

==========
//tools/binary_size: Add Disassemble() to console.py. Tweak metadata.

Might be useful for seeing why a function is big.
Reworks metadata so that the proper elf file is auto-detected under
normal circumstances.

NOTRY=true
BUG=681694

Review-Url: https://codereview.chromium.org/2801663003
Cr-Commit-Position: refs/heads/master@{#462474}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ed07a74b39aa94480fe5618c9cc...
==========

[commit-bot: I haz the power, 2017-04-06 15:01:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ed07a74b39aa94480fe5618c9cc...