Adds SVGImageElement as a ImageBitmapSource

third_party/WebKit/Source/core/svg/SVGImageElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Rob Buis <buis@kde.org>
  * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "core/svg/SVGImageElement.h"
 
 #include "core/CSSPropertyNames.h"
 #include "core/dom/StyleChangeReason.h"
+#include "core/frame/ImageBitmap.h"
+#include "core/frame/LocalDOMWindow.h"
 #include "core/layout/LayoutImageResource.h"
 #include "core/layout/svg/LayoutSVGImage.h"
 
 namespace blink {
 
 inline SVGImageElement::SVGImageElement(Document& document)
     : SVGGraphicsElement(SVGNames::imageTag, document),
       SVGURIReference(this),
       m_x(SVGAnimatedLength::create(this,
                                     SVGNames::xAttr,
@@ skipping 104 matching lines @@
     if (isConnected())
       imageLoader().updateFromElement(ImageLoader::UpdateIgnorePreviousError);
     else
       m_needsLoaderURIUpdate = true;
     return;
   }
 
   SVGGraphicsElement::svgAttributeChanged(attrName);
 }
 
+IntSize SVGImageElement::bitmapSourceSize() const {
+  ImageResourceContent* image = cachedImage();
+  if (!image)
+    return IntSize();
+  LayoutSize lSize = image->imageSize(
+      LayoutObject::shouldRespectImageOrientation(layoutObject()), 1.0f);
+  DCHECK(lSize.fraction().isZero());
+  return IntSize(lSize.width().toInt(), lSize.height().toInt());
+}
+
+ScriptPromise SVGImageElement::createImageBitmap(
+    ScriptState* scriptState,
+    EventTarget& eventTarget,
+    Optional<IntRect> cropRect,
+    const ImageBitmapOptions& options,
+    ExceptionState& exceptionState) {
+  DCHECK(eventTarget.toLocalDOMWindow());
+  if ((cropRect &&
+       !ImageBitmap::isSourceSizeValid(cropRect->width(), cropRect->height(),
+                                       exceptionState)) ||
+      !ImageBitmap::isSourceSizeValid(bitmapSourceSize().width(),
+                                      bitmapSourceSize().height(),
+                                      exceptionState))
+    return ScriptPromise();
+  if (!ImageBitmap::isResizeOptionValid(options, exceptionState))
+    return ScriptPromise();
+  return ImageBitmapSource::fulfillImageBitmap(
+      scriptState,
+      ImageBitmap::create(this, cropRect,
+                          eventTarget.toLocalDOMWindow()->document(), options));

[fs, 2017/04/06 16:48:12]

I was a bit puzzled by this until I saw what it was used for. Passing a
SecurityOrigin as early as possible might make things more clear? (That's a task
for a different CL though.)

Also, looking at the spec it seems to say "entry settings object" (entry realm),
but wouldn't this be the global object's realm? (Also not a new issue, but worth
double-checking I think.)

[fserb, 2017/04/06 20:06:16]

For the first thing, you are right.
For the second, I have no idea. :)

+}
+
 bool SVGImageElement::selfHasRelativeLengths() const {
   return m_x->currentValue()->isRelative() ||
          m_y->currentValue()->isRelative() ||
          m_width->currentValue()->isRelative() ||
          m_height->currentValue()->isRelative();
 }
 
 LayoutObject* SVGImageElement::createLayoutObject(const ComputedStyle&) {
   return new LayoutSVGImage(this);
 }
@@ skipping 46 matching lines @@
 const AtomicString SVGImageElement::imageSourceURL() const {
   return AtomicString(hrefString());
 }
 
 void SVGImageElement::didMoveToNewDocument(Document& oldDocument) {
   imageLoader().elementDidMoveToNewDocument();
   SVGGraphicsElement::didMoveToNewDocument(oldDocument);
 }
 
 }  // namespace blink