GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs
    
probe the supported GpuMemoryBufferAttribs from GpuService. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

the GpuService call is made only when there are no pending requests,
and all the incoming requests are served with the same data as received
for the first call, since we are dealing with non-changing
GpuMemoryBufferAttribs.

BUG=708947

[varad, 2017-04-06 09:07:31]

Description was changed from

==========
GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

probe the supported GpuMemoryBufferAttribs from gpu service. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

BUG=

Signed-off-by: Varad Gautam <varad.gautam@collabora.com>
==========

to

==========
GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

probe the supported GpuMemoryBufferAttribs from gpu service. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

BUG=708947

Signed-off-by: Varad Gautam <varad.gautam@collabora.com>
==========

[varad, 2017-04-06 09:34:44]

varadgautam@gmail.com changed reviewers:
+ reveman@chromium.org, sadrul@chromium.org

[varad, 2017-04-06 14:16:03]

[WIP 6/8] for GMB format/modifier communication, PTAL

[varad, 2017-04-19 15:59:51]

Description was changed from

==========
GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

probe the supported GpuMemoryBufferAttribs from gpu service. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

BUG=708947

Signed-off-by: Varad Gautam <varad.gautam@collabora.com>
==========

to

==========
GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

probe the supported GpuMemoryBufferAttribs from gpu service. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

BUG=708947
==========

[sadrul, 2017-04-19 21:45:46]

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:727:
gpu_service_ptr_->GetGpuMemoryBufferAttribs(
Maybe not make another request when a request is already in-flight (i.e. when
|get_supported_...too...long.._requests_| is not empty)?

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:800:
get_supported_gpu_memory_buffer_attribs_requests_.pop();
With the change suggested above, this would need to run all of the callbacks.

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:1084: }
Should you run all the callbacks here too?

[varad, 2017-04-21 13:02:37]

Description was changed from

==========
GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

probe the supported GpuMemoryBufferAttribs from gpu service. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

BUG=708947
==========

to

==========
GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs
    
probe the supported GpuMemoryBufferAttribs from GpuService. this is
used by GpuMemoryBufferManager instance later to query the platform
supported attribs in both mus as well as non-mus environments.

the GpuService call is made only when there are no pending requests,
and all the incoming requests are served with the same data as received
for the first call, since we are dealing with non-changing
GpuMemoryBufferAttribs.

BUG=708947
==========

[varad, 2017-04-21 13:04:00]

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:727:
gpu_service_ptr_->GetGpuMemoryBufferAttribs(
On 2017/04/19 21:45:46, sadrul wrote:
> Maybe not make another request when a request is already in-flight (i.e. when
> |get_supported_...too...long.._requests_| is not empty)?

Done.

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:800:
get_supported_gpu_memory_buffer_attribs_requests_.pop();
On 2017/04/19 21:45:46, sadrul wrote:
> With the change suggested above, this would need to run all of the callbacks.

Done.

https://codereview.chromium.org/2802663002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:1084: }
On 2017/04/19 21:45:46, sadrul wrote:
> Should you run all the callbacks here too?

Done.

[sadrul, 2017-04-26 02:46:07]

The change looks good. reveman@ should be the main reviewer though.

[reveman, 2017-05-10 17:53:21]

Don't we have some initial ipc that comes from the gpu process that can deliver
this already? E.g. could it be part of gpu::Capabilities?