GpuProcessHost: setup ipc to propagate supported GpuMemoryBufferAttribs

content/browser/gpu/gpu_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_process_host.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 699 matching lines @@
   TRACE_EVENT0("gpu", "GpuProcessHost::CreateGpuMemoryBuffer");
 
   DCHECK(CalledOnValidThread());
   create_gpu_memory_buffer_requests_.push(callback);
   gpu_service_ptr_->CreateGpuMemoryBuffer(
       id, size, format, usage, client_id, surface_handle,
       base::Bind(&GpuProcessHost::OnGpuMemoryBufferCreated,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
+void GpuProcessHost::GetGpuMemoryBufferAttribs(
+    const GetGpuMemoryBufferAttribsCallback& callback) {
+  TRACE_EVENT0("gpu", "GpuProcessHost::GetGpuMemoryBufferAttribs");
+
+  DCHECK(CalledOnValidThread());
+
+  get_supported_gpu_memory_buffer_attribs_requests_.push(callback);
+  gpu_service_ptr_->GetGpuMemoryBufferAttribs(

[sadrul, 2017/04/19 21:45:46]

Maybe not make another request when a request is already in-flight (i.e. when
|get_supported_...too...long.._requests_| is not empty)?

[varad, 2017/04/21 13:03:59]

Done.

+      base::Bind(&GpuProcessHost::OnGpuMemoryBufferAttribsReceived,
+                 weak_ptr_factory_.GetWeakPtr()));
+}
+
 void GpuProcessHost::DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferId id,
                                             int client_id,
                                             const gpu::SyncToken& sync_token) {
   TRACE_EVENT0("gpu", "GpuProcessHost::DestroyGpuMemoryBuffer");
   gpu_service_ptr_->DestroyGpuMemoryBuffer(id, client_id, sync_token);
 }
 
 #if defined(OS_ANDROID)
 void GpuProcessHost::SendDestroyingVideoSurface(int surface_id,
                                                 const base::Closure& done_cb) {
@@ skipping 43 matching lines @@
 }
 
 #if defined(OS_ANDROID)
 void GpuProcessHost::OnDestroyingVideoSurfaceAck() {
   TRACE_EVENT0("gpu", "GpuProcessHost::OnDestroyingVideoSurfaceAck");
   if (!send_destroying_video_surface_done_cb_.is_null())
     base::ResetAndReturn(&send_destroying_video_surface_done_cb_).Run();
 }
 #endif
 
+void GpuProcessHost::OnGpuMemoryBufferAttribsReceived(
+    const gfx::GpuMemoryBufferAttribVector& supported_attribs) {
+  TRACE_EVENT0("gpu", "GpuProcessHost::OnGpuMemoryBufferAttribsReceived");
+  DCHECK(!get_supported_gpu_memory_buffer_attribs_requests_.empty());
+  auto callback = get_supported_gpu_memory_buffer_attribs_requests_.front();
+  get_supported_gpu_memory_buffer_attribs_requests_.pop();

[sadrul, 2017/04/19 21:45:46]

With the change suggested above, this would need to run all of the callbacks.

[varad, 2017/04/21 13:03:59]

Done.

+  callback.Run(supported_attribs);
+}
+
 void GpuProcessHost::OnProcessLaunched() {
   UMA_HISTOGRAM_TIMES("GPU.GPUProcessLaunchTime",
                       base::TimeTicks::Now() - init_start_time_);
 }
 
 void GpuProcessHost::OnProcessLaunchFailed(int error_code) {
   // TODO(wfh): do something more useful with this error code.
   RecordProcessCrash();
 }
 
@@ skipping 260 matching lines @@
 
   while (!create_gpu_memory_buffer_requests_.empty()) {
     auto callback = create_gpu_memory_buffer_requests_.front();
     create_gpu_memory_buffer_requests_.pop();
     callback.Run(gfx::GpuMemoryBufferHandle(),
                  BufferCreationStatus::GPU_HOST_INVALID);
   }
 
   if (!send_destroying_video_surface_done_cb_.is_null())
     base::ResetAndReturn(&send_destroying_video_surface_done_cb_).Run();
 }

[sadrul, 2017/04/19 21:45:46]

Should you run all the callbacks here too?

[varad, 2017/04/21 13:03:59]

Done.

 
 void GpuProcessHost::BlockLiveOffscreenContexts() {
   for (std::multiset<GURL>::iterator iter =
            urls_with_live_offscreen_contexts_.begin();
        iter != urls_with_live_offscreen_contexts_.end(); ++iter) {
     GpuDataManagerImpl::GetInstance()->BlockDomainFrom3DAPIs(
         *iter, GpuDataManagerImpl::DOMAIN_GUILT_UNKNOWN);
   }
 }
 
@@ skipping 107 matching lines @@
   if (!cache.get())
     return;
 
   cache->set_shader_loaded_callback(base::Bind(&GpuProcessHost::LoadedShader,
                                                weak_ptr_factory_.GetWeakPtr()));
 
   client_id_to_shader_cache_[client_id] = cache;
 }
 
 }  // namespace content