Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2801723002: GpuService: introduce GetGpuMemoryBufferAttribs as a mojo interface

Created:
3 years, 8 months ago by varad
Modified:
3 years, 8 months ago
Reviewers:
reveman, sadrul
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, hoegsberg, Julien Isorce, Daniele Castagna
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

GpuService: introduce GetGpuMemoryBufferAttribs as a mojo interface allow clients to ask for the aggregate list of supported GpuMemoryBufferAttribs for all usage flags by querying GpuMemoryBufferFactory before creating/importing a GpuMemoryBuffer. we cache a list of GpuMemoryBufferAttribs here since these don't change during runtime, and would require a way to update this list to support dynamic GpuMemoryBufferAttribs. BUG=708947

Patch Set 1 #

Patch Set 2 : GpuService: introduce GetGpuMemoryBufferAttribs as a mojo interface #

Total comments: 2

Patch Set 3 : cache GpuMemoryBufferAttribs, rename GetSupportedGpuMemoryBufferAttribsForUsage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M services/ui/gpu/gpu_service.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service.mojom View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
varad
[WIP 5/8] for GMB format/modifier communication, PTAL
3 years, 8 months ago (2017-04-06 14:15:58 UTC) #3
sadrul
https://codereview.chromium.org/2801723002/diff/20001/services/ui/gpu/gpu_service.cc File services/ui/gpu/gpu_service.cc (right): https://codereview.chromium.org/2801723002/diff/20001/services/ui/gpu/gpu_service.cc#newcode268 services/ui/gpu/gpu_service.cc:268: callback.Run(supported_attribs); Do we expect this list to change between ...
3 years, 8 months ago (2017-04-19 21:40:23 UTC) #5
varad
https://codereview.chromium.org/2801723002/diff/20001/services/ui/gpu/gpu_service.cc File services/ui/gpu/gpu_service.cc (right): https://codereview.chromium.org/2801723002/diff/20001/services/ui/gpu/gpu_service.cc#newcode268 services/ui/gpu/gpu_service.cc:268: callback.Run(supported_attribs); On 2017/04/19 21:40:23, sadrul wrote: > Do we ...
3 years, 8 months ago (2017-04-21 13:01:32 UTC) #7
varad
3 years, 8 months ago (2017-04-25 06:11:32 UTC) #8

          

Powered by Google App Engine
This is Rietveld 408576698