Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2802603004: Fix broken variations fetching on Android due to ToS pref. (Closed)

Created:
3 years, 8 months ago by Alexei Svitkine (slow)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix broken variations fetching on Android due to ToS pref. In some cases, we've observed the ToS prefs to not be set at all after a backup and restore scenario, yet with the FRE not being shown. This CL attempts to fix those by ensure ToS prefs are set if FRE is marked as completed. BUG=708302 Review-Url: https://codereview.chromium.org/2803473002 Cr-Commit-Position: refs/heads/master@{#461880} (cherry picked from commit 2b81404991f0e44b9e87da014094819ca6dc1d08) Review-Url: https://codereview.chromium.org/2802603004 . Cr-Commit-Position: refs/branch-heads/3029@{#590} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d05425a9e6543d748ecd61d91c6a36ada225f06c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexei Svitkine (slow)
3 years, 8 months ago (2017-04-05 17:51:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d05425a9e6543d748ecd61d91c6a36ada225f06c.

Powered by Google App Engine
This is Rietveld 408576698