Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2803473002: Fix broken variations fetching on Android due to ToS pref. (Closed)

Created:
3 years, 8 months ago by Alexei Svitkine (slow)
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken variations fetching on Android due to ToS pref. In some cases, we've observed the ToS prefs to not be set at all after a backup and restore scenario, yet with the FRE not being shown. This CL attempts to fix those by ensure ToS prefs are set if FRE is marked as completed. BUG=708302 Review-Url: https://codereview.chromium.org/2803473002 Cr-Commit-Position: refs/heads/master@{#461880} Committed: https://chromium.googlesource.com/chromium/src/+/2b81404991f0e44b9e87da014094819ca6dc1d08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Alexei Svitkine (slow)
3 years, 8 months ago (2017-04-04 22:23:02 UTC) #4
Ted C
lgtm
3 years, 8 months ago (2017-04-04 22:29:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803473002/1
3 years, 8 months ago (2017-04-04 22:34:53 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 23:00:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b81404991f0e44b9e87da014094...

Powered by Google App Engine
This is Rietveld 408576698