Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2802503002: Start out deferring commits in WebViewImpl (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
Marc Treib, enne (OOO)
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Start out deferring commits in WebViewImpl. This is a re-land of https://codereview.chromium.org/1934513004/. The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033), or exhibit flashing even without the patch (crbug.com/608623). BUG=21798 Review-Url: https://codereview.chromium.org/2802503002 Cr-Commit-Position: refs/heads/master@{#469095} Committed: https://chromium.googlesource.com/chromium/src/+/94fdfaa5a34534601337ce1780eb8fe381f74c3b

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : Merge branch 'master' into defercommits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 38 (26 generated)
chrishtr
3 years, 8 months ago (2017-04-04 23:32:35 UTC) #4
enne (OOO)
On 2017/04/04 at 23:32:35, chrishtr wrote: >
3 years, 8 months ago (2017-04-05 00:08:55 UTC) #6
enne (OOO)
lgtm!
3 years, 8 months ago (2017-04-05 00:09:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802503002/1
3 years, 8 months ago (2017-04-05 01:51:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/264798)
3 years, 8 months ago (2017-04-05 03:35:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802503002/1
3 years, 8 months ago (2017-04-06 23:37:39 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/266712)
3 years, 8 months ago (2017-04-07 01:20:09 UTC) #17
Marc Treib
Ping! What's the status of this CL?
3 years, 7 months ago (2017-05-03 12:55:18 UTC) #26
chrishtr
I still need to debug one reproducible failure for Android webview. Will get this committed ...
3 years, 7 months ago (2017-05-03 15:10:56 UTC) #27
Marc Treib
On 2017/05/03 15:10:56, chrishtr wrote: > I still need to debug one reproducible failure for ...
3 years, 7 months ago (2017-05-03 15:36:46 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802503002/40001
3 years, 7 months ago (2017-05-03 20:01:35 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 20:05:59 UTC) #38
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/94fdfaa5a34534601337ce1780eb...

Powered by Google App Engine
This is Rietveld 408576698