|
|
DescriptionStart out deferring commits in WebViewImpl.
This is a re-land of https://codereview.chromium.org/1934513004/.
The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033),
or exhibit flashing even without the patch (crbug.com/608623).
BUG=21798
Review-Url: https://codereview.chromium.org/2802503002
Cr-Commit-Position: refs/heads/master@{#469095}
Committed: https://chromium.googlesource.com/chromium/src/+/94fdfaa5a34534601337ce1780eb8fe381f74c3b
Patch Set 1 #Patch Set 2 : none #Patch Set 3 : Merge branch 'master' into defercommits #Messages
Total messages: 38 (26 generated)
Description was changed from ========== none BUG= ========== to ========== Start out deferring commits in WebViewImpl. This is a re-land of https://codereview.chromium.org/1934513004/. The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033, or exhibit flashing even without the patch (crbug.com/608623). BUG=21798 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
chrishtr@chromium.org changed reviewers: + enne@chromium.org, treib@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/04 at 23:32:35, chrishtr wrote: >
lgtm!
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by chrishtr@chromium.org
Description was changed from ========== Start out deferring commits in WebViewImpl. This is a re-land of https://codereview.chromium.org/1934513004/. The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033, or exhibit flashing even without the patch (crbug.com/608623). BUG=21798 ========== to ========== Start out deferring commits in WebViewImpl. This is a re-land of https://codereview.chromium.org/1934513004/. The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033), or exhibit flashing even without the patch (crbug.com/608623). BUG=21798 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Ping! What's the status of this CL?
I still need to debug one reproducible failure for Android webview. Will get this committed in time for M60. If you have cycles to take it over and debug that last failure, that would be great also!
On 2017/05/03 15:10:56, chrishtr wrote: > I still need to debug one reproducible failure for Android webview. Will get > this > committed in time for M60. If you have cycles to take it over and debug that > last > failure, that would be great also! Not sure I'll be able to find the time.. if I do, I'll let you know! Anyway, M60 sounds perfect!
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2802503002/#ps40001 (title: "Merge branch 'master' into defercommits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493841661481670, "parent_rev": "008b9b947994dd0311a14015660df1b30126247d", "commit_rev": "94fdfaa5a34534601337ce1780eb8fe381f74c3b"}
Message was sent while issue was closed.
Description was changed from ========== Start out deferring commits in WebViewImpl. This is a re-land of https://codereview.chromium.org/1934513004/. The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033), or exhibit flashing even without the patch (crbug.com/608623). BUG=21798 ========== to ========== Start out deferring commits in WebViewImpl. This is a re-land of https://codereview.chromium.org/1934513004/. The two bugs leading to revert of that patch seem to be either ok (crbug.com/609033), or exhibit flashing even without the patch (crbug.com/608623). BUG=21798 Review-Url: https://codereview.chromium.org/2802503002 Cr-Commit-Position: refs/heads/master@{#469095} Committed: https://chromium.googlesource.com/chromium/src/+/94fdfaa5a34534601337ce1780eb... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/94fdfaa5a34534601337ce1780eb... |