Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1934513004: Start out deferring commits in WebViewImpl. (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu, enne (OOO)
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start out deferring commits in WebViewImpl. This is analogous to the call in WebViewImpl::setRootGraphicsLayer when deleting the root graphics layer (as a proxy for detecting page navigation), but for when starting up a new WebViewImpl. BUG=470669 Committed: https://crrev.com/eb72314ba51288a9e0b8b351286a375d6065763f Cr-Commit-Position: refs/heads/master@{#390865}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
chrishtr
4 years, 7 months ago (2016-04-29 20:14:09 UTC) #3
Xianzhu
lgtm
4 years, 7 months ago (2016-04-29 20:26:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934513004/20001
4 years, 7 months ago (2016-04-29 20:34:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/220150)
4 years, 7 months ago (2016-04-29 21:45:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934513004/20001
4 years, 7 months ago (2016-04-30 21:22:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-30 23:21:20 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eb72314ba51288a9e0b8b351286a375d6065763f Cr-Commit-Position: refs/heads/master@{#390865}
4 years, 7 months ago (2016-04-30 23:22:20 UTC) #13
chrishtr
4 years, 7 months ago (2016-05-04 15:05:13 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1952673002/ by chrishtr@chromium.org.

The reason for reverting is: Caused 608623 and 609033.

Powered by Google App Engine
This is Rietveld 408576698