Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2802353002: getImageData now finalizesFrame and disableAcceleration updates composit (Closed)

Created:
3 years, 8 months ago by fserb
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

getImageData now finalizesFrame and disableAcceleration updates composit Both are needed for proper accelerate to software conversion. getImageData wasn't calling needFinalizeFrame, so frames that only called it, wouldn't be moved to software. Also, when converting from accelerate, background-color/alpha wasn't being properly propagated because we didn't updated compositing. BUG= Review-Url: https://codereview.chromium.org/2802353002 Cr-Commit-Position: refs/heads/master@{#463307} Committed: https://chromium.googlesource.com/chromium/src/+/67774f8b275a884f3571cbb0f24a687c73380a7e

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fserb
3 years, 8 months ago (2017-04-07 20:36:57 UTC) #2
Justin Novosad
lgtm
3 years, 8 months ago (2017-04-09 01:54:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802353002/1
3 years, 8 months ago (2017-04-09 18:11:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187008) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-09 18:13:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802353002/20001
3 years, 8 months ago (2017-04-10 15:57:14 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:24:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67774f8b275a884f3571cbb0f24a...

Powered by Google App Engine
This is Rietveld 408576698