third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h - Issue 2802353002: getImageData now finalizesFrame and disableAcceleration updates composit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

Issue 2802353002: getImageData now finalizesFrame and disableAcceleration updates composit (Closed)

Patch Set: merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

index 0a617c4ebdd5a6e135ac82efc436fc5444423ad3..3b2703f77018436063a8469e49b4f5ce5279dba3 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

@@ -187,11 +187,7 @@ class MODULES_EXPORT BaseRenderingContext2D : public GarbageCollectedMixin,

ImageData* createImageData(ImageData*, ExceptionState&) const;

ImageData* createImageData(int width, int height, ExceptionState&) const;

- ImageData* getImageData(int sx,

- int sy,

- int sw,

- int sh,

- ExceptionState&) const;

+ ImageData* getImageData(int sx, int sy, int sw, int sh, ExceptionState&);

void putImageData(ImageData*, int dx, int dy, ExceptionState&);

void putImageData(ImageData*,

int dx,

@@ -342,6 +338,8 @@ class MODULES_EXPORT BaseRenderingContext2D : public GarbageCollectedMixin,

float EstimateRenderingCost(

ExpensiveCanvasHeuristicParameters::RenderingModeCostIndex) const;

+ virtual void NeedsFinalizeFrame(){};

private:

void RealizeSaves();