Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Issue 2802283002: Fix find-in-page "1 of 0" bug. (Closed)

Created:
3 years, 8 months ago by paulmeyer
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix find-in-page "1 of 0" bug. This patch enabled FindRequestManager to update the active match ordinal properly when all matches are dynamically removed from the page between subsequent find requests. BUG=707798 Review-Url: https://codereview.chromium.org/2790213002 Cr-Commit-Position: refs/heads/master@{#461522} (cherry picked from commit 0f4e7a51e872861c59e466cbb498caa4ea54b808) Review-Url: https://codereview.chromium.org/2802283002 . Cr-Commit-Position: refs/branch-heads/3029@{#625} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/78afc8b02f24bd416c58f4c4d58c3bf0c0c7f8b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/find_request_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
paulmeyer
3 years, 8 months ago (2017-04-07 18:17:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78afc8b02f24bd416c58f4c4d58c3bf0c0c7f8b8.

Powered by Google App Engine
This is Rietveld 408576698