Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2790213002: Fix find-in-page "1 of 0" bug. (Closed)

Created:
3 years, 8 months ago by paulmeyer
Modified:
3 years, 8 months ago
Reviewers:
lfg
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix find-in-page "1 of 0" bug. This patch enabled FindRequestManager to update the active match ordinal properly when all matches are dynamically removed from the page between subsequent find requests. BUG=707798 Review-Url: https://codereview.chromium.org/2790213002 Cr-Commit-Position: refs/heads/master@{#461522} Committed: https://chromium.googlesource.com/chromium/src/+/0f4e7a51e872861c59e466cbb498caa4ea54b808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/find_request_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
paulmeyer
+lfg@
3 years, 8 months ago (2017-04-03 18:23:52 UTC) #2
lfg
lgtm
3 years, 8 months ago (2017-04-03 18:33:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790213002/1
3 years, 8 months ago (2017-04-03 18:59:29 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 20:28:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f4e7a51e872861c59e466cbb498...

Powered by Google App Engine
This is Rietveld 408576698