third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl - Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails. (Closed)

Patch Set: Add |callback_function_name| to the callback function template Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_callback_function.py ('k') | third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

index 50e3b25f6728ce7f06c67f4a1120ba8640239e42..8390f85535d9592c3dcb32121768fa70dd6078ce 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

@@ -81,7 +81,10 @@ bool {{cpp_class}}::call({{argument_declarations | join(', ')}}) {

}

{{cpp_class}}* NativeValueTraits<{{cpp_class}}>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {

- return {{cpp_class}}::create(ScriptState::current(isolate), value);

+ {{cpp_class}}* nativeValue = {{cpp_class}}::create(ScriptState::current(isolate), value);

+ if (!nativeValue)

+ exceptionState.throwTypeError("Unable to convert value to {{callback_function_name}}.");

+ return nativeValue;

}

} // namespace blink