third_party/WebKit/Source/bindings/scripts/v8_callback_function.py - Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails. (Closed)

Patch Set: Add |callback_function_name| to the callback function template Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

index 1bbd2cb9a4e2fa86e48851c1a30b7810493877c5..37be007b8e64779f5b0f55a0e863ea9e451c1183 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

@@ -39,6 +39,11 @@ def callback_function_context(callback_function):

argument.idl_type.add_includes_for_type(callback_function.extended_attributes)

context = {

+ # While both |callback_function_name| and |cpp_class| are identical at

+ # the moment, the two are being defined because their values may change

+ # in the future (e.g. if we support [ImplementedAs=] in callback

+ # functions).

+ 'callback_function_name': callback_function.name,

'cpp_class': callback_function.name,

'cpp_includes': sorted(includes),

'forward_declarations': sorted(forward_declarations),