third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl - Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails. (Closed)

Patch Set: Add |callback_function_name| to the callback function template Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

index 7ed4d7fc98e4581c2e4b3d1c61e923f1bff1b3c4..e840b30e4d2e371a0a757ef362698e425b79a28d 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

@@ -892,7 +892,10 @@ v8::Local<v8::Object> {{v8_class}}::findInstanceInPrototypeChain(v8::Local<v8::V

{##############################################################################}

{% block native_value_traits %}

{{cpp_class}}* NativeValueTraits<{{cpp_class}}>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {

- return {{v8_class}}::toImplWithTypeCheck(isolate, value);

+ {{cpp_class}}* nativeValue = {{v8_class}}::toImplWithTypeCheck(isolate, value);

+ if (!nativeValue)

+ exceptionState.throwTypeError("Unable to convert value to {{interface_name}}.");

+ return nativeValue;

}

{% endblock %}