Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2802143002: [Mac] Fix for the tab detach position (Closed)

Created:
3 years, 8 months ago by spqchan
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, dcheng, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for the tab detach position BUG=704579 Review-Url: https://codereview.chromium.org/2802143002 Cr-Commit-Position: refs/heads/master@{#462921} Committed: https://chromium.googlesource.com/chromium/src/+/5ec735024b7275e96970796f14bff80e1e9ae6a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
spqchan
PTAL
3 years, 8 months ago (2017-04-07 00:24:05 UTC) #4
Robert Sesek
LGTM
3 years, 8 months ago (2017-04-07 17:54:01 UTC) #7
spqchan
On 2017/04/07 17:54:01, Robert Sesek wrote: > LGTM thanks!
3 years, 8 months ago (2017-04-07 17:56:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802143002/1
3 years, 8 months ago (2017-04-07 17:57:08 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 18:09:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ec735024b7275e96970796f14bf...

Powered by Google App Engine
This is Rietveld 408576698