Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

Issue 2802143002: [Mac] Fix for the tab detach position (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
index 2e6e3378486d30d0dd24926ca5f166517cc8b252..a46fe9f4c864a26e5d503a9e583d9163a2b4501d 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
@@ -352,9 +352,11 @@ static BOOL PointIsInsideView(NSPoint screenPoint, NSView* view) {
// See http://crbug.com/687647.
NSPoint origin = sourceWindowFrame_.origin;
origin.x += (thisPoint.x - dragOrigin_.x);
- origin.y +=
- (thisPoint.y - dragOrigin_.y) +
- ([sourceController_ menubarOffset] + [sourceController_ menubarHeight]);
+ origin.y += (thisPoint.y - dragOrigin_.y);
+ if ([sourceController_ isInAnyFullscreenMode]) {
+ origin.y +=
+ [sourceController_ menubarOffset] + [sourceController_ menubarHeight];
+ }
if (tearProgress < 1) {
// If the tear animation is not complete, call back to ourself with the
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698