precache: Extract common methods for PrecacheManifest into util.

precache: Extract common methods for PrecacheManifest into util.

The GetResourceBitset() function is needed for both ResourcePrefetchPredictor
and PrecacheFetcher. This CL extracts util functions into a separate file to
allow to reuse the same code.

BUG=699115
Review-Url: https://codereview.chromium.org/2802053002
Cr-Commit-Position: refs/heads/master@{#463236}
Committed: https://chromium.googlesource.com/chromium/src/+/f73af7b0dc19fe2ee514c6848c013388c1d6427a

[alexilin, 2017-04-06 17:21:32]

alexilin@chromium.org changed reviewers:
+ lizeb@chromium.org

[alexilin, 2017-04-06 17:21:32]

Hi lizeb,

I know you don't like moving code, but I want to reuse this damn function that's
a part of the implementation now.
Of course, I can move it into precache_fetcher.h if it's more suitable for you.

[Benoit L, 2017-04-10 09:52:51]

On 2017/04/06 17:21:32, alexilin wrote:
> Hi lizeb,
> 
> I know you don't like moving code, but I want to reuse this damn function
that's
> a part of the implementation now.
> Of course, I can move it into precache_fetcher.h if it's more suitable for
you.

I don't like moving code when it doesn't bring benefits, and re-using a function
is a net positive. :-)
lgtm

[alexilin, 2017-04-10 11:53:58]

The CQ bit was checked by alexilin@chromium.org

[commit-bot: I haz the power, 2017-04-10 11:54:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 12:49:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491825238037060,
"parent_rev": "22b66d18003ac13537ea52fc30f3ab091da30312", "commit_rev":
"f73af7b0dc19fe2ee514c6848c013388c1d6427a"}

[commit-bot: I haz the power, 2017-04-10 12:50:17]

Description was changed from

==========
precache: Extract common methods for PrecacheManifest into util.

The GetResourceBitset() function is needed for both ResourcePrefetchPredictor
and PrecacheFetcher. This CL extracts util functions into a separate file to
allow to reuse the same code.

BUG=699115
==========

to

==========
precache: Extract common methods for PrecacheManifest into util.

The GetResourceBitset() function is needed for both ResourcePrefetchPredictor
and PrecacheFetcher. This CL extracts util functions into a separate file to
allow to reuse the same code.

BUG=699115

Review-Url: https://codereview.chromium.org/2802053002
Cr-Commit-Position: refs/heads/master@{#463236}
Committed:
https://chromium.googlesource.com/chromium/src/+/f73af7b0dc19fe2ee514c6848c01...
==========

[commit-bot: I haz the power, 2017-04-10 12:50:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f73af7b0dc19fe2ee514c6848c01...