Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor.cc

Issue 2802053002: precache: Extract common methods for PrecacheManifest into util. (Closed)
Patch Set: Copyright. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | components/precache/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/predictors/resource_prefetch_predictor.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor.cc b/chrome/browser/predictors/resource_prefetch_predictor.cc
index 7b9979906fb4a7a074304f966c5304088ed5fcee..63fcbc6fc439aabc8f6006a4b41ef5b01923e6e4 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor.cc
@@ -23,6 +23,7 @@
#include "components/history/core/browser/history_service.h"
#include "components/history/core/browser/url_utils.h"
#include "components/mime_util/mime_util.h"
+#include "components/precache/core/precache_manifest_util.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/browser/web_contents.h"
@@ -221,22 +222,6 @@ void ReportPredictionAccuracy(
static_cast<int>(redirect_status), static_cast<int>(RedirectStatus::MAX));
}
-void RemoveUnknownFieldsFromPrecacheManifest(
- precache::PrecacheManifest* manifest) {
- manifest->mutable_unknown_fields()->clear();
- for (auto& resource : *manifest->mutable_resource())
- resource.mutable_unknown_fields()->clear();
- if (manifest->has_experiments()) {
- manifest->mutable_experiments()->mutable_unknown_fields()->clear();
- for (auto& kv : *manifest->mutable_experiments()
- ->mutable_resources_by_experiment_group()) {
- kv.second.mutable_unknown_fields()->clear();
- }
- }
- if (manifest->has_id())
- manifest->mutable_id()->mutable_unknown_fields()->clear();
-}
-
} // namespace
////////////////////////////////////////////////////////////////////////////////
@@ -1482,7 +1467,7 @@ void ResourcePrefetchPredictor::OnManifestFetched(
cache_entry->second = manifest;
}
- RemoveUnknownFieldsFromPrecacheManifest(&cache_entry->second);
+ precache::RemoveUnknownFields(&cache_entry->second);
BrowserThread::PostTask(
BrowserThread::DB, FROM_HERE,
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | components/precache/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698