Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2801923003: chromeos: Fix chrome --mus startup crash on device (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, shuchen+watch_chromium.org, yusukes+watch_chromium.org, mohsen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Fix chrome --mus startup crash on device For now we need to use the fake IME for both --mus and --mash. There's still another startup crash, but that will take a little more work to fix. BUG=709097 TEST=manual TBR=zork@chromium.org Review-Url: https://codereview.chromium.org/2801923003 Cr-Commit-Position: refs/heads/master@{#462641} Committed: https://chromium.googlesource.com/chromium/src/+/205ee990e92962dbe5a0cceed476680c055c43b1

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (16 generated)
James Cook
mohsen, please take a look.
3 years, 8 months ago (2017-04-06 18:21:23 UTC) #3
mohsen
I'm not familiar with this code. Not sure why there is a TODO for me ...
3 years, 8 months ago (2017-04-06 18:30:31 UTC) #6
kylechar
lgtm with one nit. https://codereview.chromium.org/2801923003/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl.cc File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/2801923003/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl.cc#newcode924 chrome/browser/chromeos/input_method/input_method_manager_impl.cc:924: // TODO(mohsen): Revisit using FakeImeKeyboard ...
3 years, 8 months ago (2017-04-06 19:36:23 UTC) #9
James Cook
zork, can I get OWNERS? This only affects the mustash project, it's not yet a ...
3 years, 8 months ago (2017-04-06 19:43:42 UTC) #13
James Cook
Looks like zork is OOO. I'm going to TBR since this is blocking running on ...
3 years, 8 months ago (2017-04-06 21:34:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801923003/20001
3 years, 8 months ago (2017-04-06 21:35:30 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/205ee990e92962dbe5a0cceed476680c055c43b1
3 years, 8 months ago (2017-04-06 22:08:49 UTC) #23
Zachary Kuznia
3 years, 8 months ago (2017-04-06 22:09:02 UTC) #24
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698