|
|
Created:
3 years, 8 months ago by James Cook Modified:
3 years, 8 months ago CC:
chromium-reviews, davemoore+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, shuchen+watch_chromium.org, yusukes+watch_chromium.org, mohsen Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionchromeos: Fix chrome --mus startup crash on device
For now we need to use the fake IME for both --mus and --mash.
There's still another startup crash, but that will take a little more
work to fix.
BUG=709097
TEST=manual
TBR=zork@chromium.org
Review-Url: https://codereview.chromium.org/2801923003
Cr-Commit-Position: refs/heads/master@{#462641}
Committed: https://chromium.googlesource.com/chromium/src/+/205ee990e92962dbe5a0cceed476680c055c43b1
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix comment #
Dependent Patchsets: Messages
Total messages: 24 (16 generated)
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
jamescook@chromium.org changed reviewers: + mohsen@chromium.org
mohsen, please take a look.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mohsen@chromium.org changed reviewers: + kylechar@chromium.org
I'm not familiar with this code. Not sure why there is a TODO for me there :-) Assigning to kylechar@...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with one nit. https://codereview.chromium.org/2801923003/diff/1/chrome/browser/chromeos/inp... File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/2801923003/diff/1/chrome/browser/chromeos/inp... chrome/browser/chromeos/input_method/input_method_manager_impl.cc:924: // TODO(mohsen): Revisit using FakeImeKeyboard with mash when InputController Can you change the TODO to be TODO(crbug.com/642863) and remove the link to crbug.com/601981?
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jamescook@chromium.org changed reviewers: + zork@chromium.org - mohsen@chromium.org
zork, can I get OWNERS? This only affects the mustash project, it's not yet a shipping configuration. https://codereview.chromium.org/2801923003/diff/1/chrome/browser/chromeos/inp... File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/2801923003/diff/1/chrome/browser/chromeos/inp... chrome/browser/chromeos/input_method/input_method_manager_impl.cc:924: // TODO(mohsen): Revisit using FakeImeKeyboard with mash when InputController On 2017/04/06 19:36:23, kylechar wrote: > Can you change the TODO to be TODO(crbug.com/642863) and remove the link to > crbug.com/601981? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== chromeos: Fix chrome --mus startup crash on device For now we need to use the fake IME for both --mus and --mash. There's still another startup crash, but that will take a little more work to fix. BUG=709097 TEST=manual ========== to ========== chromeos: Fix chrome --mus startup crash on device For now we need to use the fake IME for both --mus and --mash. There's still another startup crash, but that will take a little more work to fix. BUG=709097 TEST=manual TBR=zork@chromium.org ==========
Looks like zork is OOO. I'm going to TBR since this is blocking running on device and it only affects mustash.
The CQ bit was checked by jamescook@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kylechar@chromium.org Link to the patchset: https://codereview.chromium.org/2801923003/#ps20001 (title: "fix comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491514450079780, "parent_rev": "7ce718fb7d7e6cfb17735b573458d578feb02e7e", "commit_rev": "205ee990e92962dbe5a0cceed476680c055c43b1"}
Message was sent while issue was closed.
Description was changed from ========== chromeos: Fix chrome --mus startup crash on device For now we need to use the fake IME for both --mus and --mash. There's still another startup crash, but that will take a little more work to fix. BUG=709097 TEST=manual TBR=zork@chromium.org ========== to ========== chromeos: Fix chrome --mus startup crash on device For now we need to use the fake IME for both --mus and --mash. There's still another startup crash, but that will take a little more work to fix. BUG=709097 TEST=manual TBR=zork@chromium.org Review-Url: https://codereview.chromium.org/2801923003 Cr-Commit-Position: refs/heads/master@{#462641} Committed: https://chromium.googlesource.com/chromium/src/+/205ee990e92962dbe5a0cceed476... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/205ee990e92962dbe5a0cceed476...
Message was sent while issue was closed.
lgtm |